Repository navigation
fix: avoid immediate keepalive pings to prevent flagd GOAWAY - #463
Open
buildingisfun23 wants to merge 1 commit into
Open
buildingisfun23 wants to merge 1 commit into
buildingisfun23 wants to merge 1 commit into
Conversation
FlagdProvider default keep_alive_time = 0 made the gRPC C-core ping immediately and triggered flagd's grpc-go GOAWAY. I set DEFAULT_KEEP_ALIVE to 600000 ms and only add grpc.keepalive_time_ms when keep_alive_time > 0. This prevents immediate pings and lets the channel use gRPC defaults for zero, avoiding the GOAWAY. Tested with unit tests and an end-to-end repro against flagd. Assisted-by: glm-5.3-flash Signed-off-by: Vikas Rao <mvrao@uci.edu>
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
buildingisfun23
marked this pull request as ready for review
October 21, 2026 05:02
aepfli
approved these changes
Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #365
FlagdProvider default keep_alive_time = 0 made the gRPC C-core ping immediately and triggered flagd's grpc-go GOAWAY. I set DEFAULT_KEEP_ALIVE to 600000 ms and only add grpc.keepalive_time_ms when keep_alive_time > 0. This prevents immediate pings and lets the channel use gRPC defaults for zero, avoiding the GOAWAY. Tested with unit tests and an end-to-end repro against flagd.
Tested with
uv run --no-sync pytest -q: no new test failures (11 tests already failed before the change).