Skip to content

strokeCap prop on circle not being used by Arc #63

Closed

Description

@byronhallett

I can't see why this is happening from reading the source.

My inspector shows that strokeCap: 'round' is set on progress circle, but the Arc objects below are still 'butt'.

have confirmed using version:
react-native-progress@3.3.0

screen shot 2017-07-05 at 6 00 07 pm
screen shot 2017-07-05 at 6 00 45 pm

Activity

  1. byronhallett commented on Jul 5, 2017

    @byronhallett
    ContributorAuthor

    ahh, I see what was wrong.

    My expected behaviour was that the foreground shape would use strokeCap. Is that supposed to be the case?
    Currently, the Circle.js render() function passes strokeCap to the props of the border Arc, but not to the background or foreground arc (the component type named "Shape" within this scope)

    Locally, I have added:
    strokeCap={strokeCap}
    at Circle.js:150

    Should the repo be updated this way too?

  2. oblador commented on Jul 5, 2017

    @oblador
    Owner

    That sounds wrong yes, care to do a PR?

  3. byronhallett commented on Jul 6, 2017

    @byronhallett
    ContributorAuthor

    No problem, just created #65

    I am going to make a further change to my new fork, since my project wants an open circle like the one below.
    Do you think that is something you might want a PR for as well?

    screen shot 2017-07-06 at 11 44 10 am

  4. oblador commented on Aug 22, 2017

    @oblador
    Owner

    Fixed in 3.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions