You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
strokeCap prop on circle not being used by Arc #63
My expected behaviour was that the foreground shape would use strokeCap. Is that supposed to be the case?
Currently, the Circle.js render() function passes strokeCap to the props of the border Arc, but not to the background or foreground arc (the component type named "Shape" within this scope)
Locally, I have added:
strokeCap={strokeCap}
at Circle.js:150
I am going to make a further change to my new fork, since my project wants an open circle like the one below.
Do you think that is something you might want a PR for as well?
Activity
byronhallett commentedon Jul 5, 2017
ahh, I see what was wrong.
My expected behaviour was that the foreground shape would use strokeCap. Is that supposed to be the case?
Currently, the Circle.js render() function passes strokeCap to the props of the border Arc, but not to the background or foreground arc (the component type named "Shape" within this scope)
Locally, I have added:
strokeCap={strokeCap}
at Circle.js:150
Should the repo be updated this way too?
oblador commentedon Jul 5, 2017
That sounds wrong yes, care to do a PR?
byronhallett commentedon Jul 6, 2017
No problem, just created #65
I am going to make a further change to my new fork, since my project wants an open circle like the one below.
Do you think that is something you might want a PR for as well?
oblador commentedon Aug 22, 2017
Fixed in 3.4.0.