You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(components)!: use ghost xs close and remove buttons - #7465
📖 Documentation (updates to the documentation or readme)
🐞 Bug fix (a non-breaking change that fixes an issue)
👌 Enhancement (improving an existing functionality)
✨ New feature (a non-breaking change that adds functionality)
🧹 Chore (updates to the build process or auxiliary tools and libraries)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)
📚 Description
Follow-up to #7425. The close button of Alert and Toast, the remove button of a FileUpload file in the list layout and the buttons of a queued ChatPrompt message were link buttons, while the other built-in close buttons and every field button are ghost.
They're now ghost and xs through props. Alert and Toast hand the padding back with -m-(--ui-control-py), so the box takes the room of the icon alone and nothing moves, at any size passed through close. FileUpload already did that with -me-(--ui-control-py), so its theme doesn't change. A hovered queue row goes from bg-soft to bg-tint so the hover of its buttons shows.
The close icons go from 16px to 14px. On a solid Alert the neutral hover still reads as a gray square on the color, that needs the on-colored-surface scope of #6610 rather than a class on the button.
The captures compare the v5 preview with this branch's on the docs examples, light and dark:
⚠️2 benchmarks with a significant change ran on different hardware
Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.
⚠️2 benchmarks with a significant change ran in a different software environment
Their base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the changes might come from this difference rather than from the code. Open an affected benchmark to see what changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Part of #6918, Epic B of #6610
❓ Type of change
📚 Description
Follow-up to #7425. The close button of Alert and Toast, the remove button of a FileUpload file in the
listlayout and the buttons of a queued ChatPrompt message werelinkbuttons, while the other built-in close buttons and every field button areghost.They're now
ghostandxsthrough props. Alert and Toast hand the padding back with-m-(--ui-control-py), so the box takes the room of the icon alone and nothing moves, at anysizepassed throughclose. FileUpload already did that with-me-(--ui-control-py), so its theme doesn't change. A hovered queue row goes frombg-softtobg-tintso the hover of its buttons shows.The close icons go from 16px to 14px. On a solid Alert the neutral hover still reads as a gray square on the color, that needs the on-colored-surface scope of #6610 rather than a class on the button.
The captures compare the
v5preview with this branch's on the docs examples, light and dark:📝 Checklist