Skip to content

feat(components)!: use ghost xs close and remove buttons - #7465

Draft
benjamincanac wants to merge 2 commits into
v5from
feat/ghost-close
Draft

benjamincanac wants to merge 2 commits into
v5from
feat/ghost-close

Conversation

@benjamincanac

@benjamincanac benjamincanac commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

🔗 Linked issue

Part of #6918, Epic B of #6610

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Follow-up to #7425. The close button of Alert and Toast, the remove button of a FileUpload file in the list layout and the buttons of a queued ChatPrompt message were link buttons, while the other built-in close buttons and every field button are ghost.

They're now ghost and xs through props. Alert and Toast hand the padding back with -m-(--ui-control-py), so the box takes the room of the icon alone and nothing moves, at any size passed through close. FileUpload already did that with -me-(--ui-control-py), so its theme doesn't change. A hovered queue row goes from bg-soft to bg-tint so the hover of its buttons shows.

The close icons go from 16px to 14px. On a solid Alert the neutral hover still reads as a gray square on the color, that needs the on-colored-surface scope of #6610 rather than a class on the button.

The captures compare the v5 preview with this branch's on the docs examples, light and dark:

Alert close

FileUpload remove

ChatPrompt queue

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ui Ready Ready Preview Nov 20, 2026 5:18pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
ui-repl Ignored Ignored Nov 20, 2026 5:18pm UTC

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

Client output of the apps in test/bundle that changed, compared to the base branch.

Fixture JS (gzip) CSS (gzip)
nuxt 116.8 kB (+7 B, +0.0%) 33.3 kB (+15 B, +0.0%)
nuxt-detection 116.8 kB (+7 B, +0.0%) 13.1 kB (+14 B, +0.1%)
nuxt-full 861.4 kB (+32 B, +0.0%) 33.5 kB (+15 B, +0.0%)
vue 93.9 kB (+7 B, +0.0%) 31.8 kB (+15 B, +0.0%)
vue-detection 93.9 kB (+7 B, +0.0%) 11.4 kB (+12 B, +0.1%)
Raw sizes
Fixture JS CSS
nuxt 318.4 kB (+28 B, +0.0%) 221.1 kB (+63 B, +0.0%)
nuxt-detection 318.4 kB (+28 B, +0.0%) 68.9 kB (+48 B, +0.1%)
nuxt-full 2683.5 kB (+62 B, +0.0%) 221.4 kB (+63 B, +0.0%)
vue 265.1 kB (+28 B, +0.0%) 224.2 kB (+63 B, +0.0%)
vue-detection 265.1 kB (+28 B, +0.0%) 66.6 kB (+48 B, +0.1%)

@codspeed

codspeed Bot commented Nov 20, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

2 warnings

⚠️ 2 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚠️ 2 benchmarks with a significant change ran in a different software environment

Their base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the changes might come from this difference rather than from the code. Open an affected benchmark to see what changed.

See affected benchmarks

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 34 untouched benchmarks
⏩ 10 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ button 831.4 µs 939.3 µs -11.48%
⚡ table 3.2 ms 2.2 ms +45.42%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing feat/ghost-close (b1aa5b9) with v5 (05424d9)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@pkg-pr-new

pkg-pr-new Bot commented Nov 20, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@nuxt/ui@7465

commit: b1aa5b9

This branch was successfully deployed

1 active deployment
Preview – ui — b1aa5b99 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v5 #6918

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant