Repository navigation
Conversation
Collaborator
|
Review requested:
|
Collaborator
Collaborator
Member
Author
|
Shared library build at https://ci.nodejs.org/job/node-test-commit-aix-shared-lib/nodes=aix73-power9/2617 worked with one exception - but that's much better than previously. Noting that the test does have a block for Windows: but in our case it does pass on AIX in the non-shared builds. Incoming force push to update commit message, but no extra code changes. |
Signed-off-by: Stewart X Addison <sxa@ibm.com> Assisted-by: Cursor
Collaborator
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Collaborator
Member
Author
|
reason for the failure may be related to the runtimelin linking options (or lack of them!) in the shared library builds. Latest commit will try to resolve that by adding this to the shared library clause: Related: #15286 |
Signed-off-by: Stewart X Addison <sxa@ibm.com>
…sure exp is a prereq of the headers phase Signed-off-by: Stewart X Addison <sxa@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.