Skip to content

build: fix AIX shared library exports generation - #67359

Draft
sxa wants to merge 4 commits into
nodejs:mainfrom
sxa:aix_shared_patch
Draft

sxa wants to merge 4 commits into
nodejs:mainfrom
sxa:aix_shared_patch

Conversation

@sxa

@sxa sxa commented Nov 9, 2026

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Nov 9, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@sxa

sxa commented Nov 9, 2026 •

Copy link
Copy Markdown
Member Author

Shared library build at https://ci.nodejs.org/job/node-test-commit-aix-shared-lib/nodes=aix73-power9/2617 worked with one exception - but that's much better than previously.

not ok 7282 addons/dlopen-ping-pong/test
  ---
  duration_ms: 280.95800
  severity: crashed
  exitcode: -4
  stack: |-
    process.dlopen: /home/iojs/build/workspace/node-test-commit-aix-shared-lib/nodes/aix73-power9/test/addons/dlopen-ping-pong/build/Release/binding.node
    module.exports.load: /home/iojs/build/workspace/node-test-commit-aix-shared-lib/nodes/aix73-power9/test/addons/dlopen-ping-pong/build/Release/ping.so
  ...

Noting that the test does have a block for Windows:

if (common.isWindows)
  common.skip('dlopen global symbol loading is not supported on this os.');

but in our case it does pass on AIX in the non-shared builds.

Incoming force push to update commit message, but no extra code changes.

Signed-off-by: Stewart X Addison <sxa@ibm.com>
Assisted-by: Cursor
@sxa
sxa force-pushed the aix_shared_patch branch from 9a4d75c to 22b6f33 Compare November 9, 2026 18:35
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Signed-off-by: Stewart X Addison <sxa@ibm.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@sxa

sxa commented Nov 9, 2026 •

Copy link
Copy Markdown
Member Author

reason for the failure may be related to the runtimelin linking options (or lack of them!) in the shared library builds. Latest commit will try to resolve that by adding this to the shared library clause:

'-Wl,-brtl',

Related: #15286

sxa added 2 commits November 10, 2026 00:15
Signed-off-by: Stewart X Addison <sxa@ibm.com>
…sure exp is a prereq of the headers phase

Signed-off-by: Stewart X Addison <sxa@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants