Repository navigation
fs: fix do_not_throw_error argument index in sync fstat - #66637
Open
daniellockyer wants to merge 1 commit into
Open
daniellockyer wants to merge 1 commit into
daniellockyer wants to merge 1 commit into
Conversation
nodejs-github-bot
added
c++
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
The synchronous branch of the fstat binding read its do_not_throw_error flag from args[2], which is always undefined on that branch, so the flag was ignored and the binding always threw. Read the flag from args[3] as documented, and restore tryStatSync() to closing the file descriptor it owns before rethrowing the fstat error, which was its behaviour before the flag was introduced. Refs: nodejs#49868 Assisted-by: MiniMax M3.1 Flash Preview + Opus 5.5 Signed-off-by: Daniel Lockyer <hi@daniellockyer.com>
daniellockyer
force-pushed
the
fs-fstat-sync-arg-index
branch
from
October 10, 2026 07:09
2ea782d to
593b5bd
Compare
addaleax
reviewed
Oct 30, 2026
| stats = binding.fstat(fd, false, undefined, false); | ||
| threw = false; | ||
| } finally { | ||
| if (threw && !isUserFd) fs.closeSync(fd); | ||
| } |
Member
There was a problem hiding this comment.
Can you explain why we're switching shouldNotThrow from true to false and adding try/catch? The C++ fix seems unambiguously correct, but the motivation for the corresponding JS changes isn't really explained anywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The synchronous branch of the fstat binding read its
do_not_throw_errorflag fromargs[2], which is always undefined on that branch, so the flag was ignored and the binding always threw.Read the flag from
args[3]as documented, and restoretryStatSync()to closing the file descriptor it owns before re-throwing the fstat error, which was its behavior before the flag was introduced.Refs: #49868
Assisted-by: MiniMax M3.1 Flash Preview + Opus 5.5