Repository navigation
stream: destroy fixes - #29058
Closed
ronag wants to merge 2 commits into
Closed
stream: destroy fixes#29058ronag wants to merge 2 commits into
ronag wants to merge 2 commits into
Conversation
ronag
force-pushed
the
stream-no-error-after-error
branch
18 times, most recently
from
August 9, 2019 07:56
d6cc7ba to
f82b56a
Compare
3 of 4 tasks
2 tasks done
Member
Author
|
@mcollina: I tried combining some PR's into commits in one PR to ease review. I think this is how you prefer it? |
ronag
force-pushed
the
stream-no-error-after-error
branch
7 times, most recently
from
August 9, 2019 15:59
c0bb972 to
8e1883c
Compare
Trott
reviewed
Aug 15, 2019
Trott
approved these changes
Aug 15, 2019
commented
Aug 15, 2019
Collaborator
commented
Aug 15, 2019
Member
|
CITGM for master: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1951/ |
commented
Aug 15, 2019
Member
|
@mcollina OK to remove |
commented
Aug 16, 2019
Collaborator
commented
Aug 16, 2019
Collaborator
commented
Aug 16, 2019
Collaborator
mcollina
removed
the
tsc-agenda
commented
Aug 16, 2019
Member
|
@Trott removed |
ronag
force-pushed
the
stream-no-error-after-error
branch
from
August 16, 2019 09:07
8558a3c to
b432d4d
Compare
commented
Aug 16, 2019
Member
Author
|
That force push was a mistake and has been reverted. |
ronag
force-pushed
the
stream-no-error-after-error
branch
from
August 16, 2019 11:02
b432d4d to
5c1fb91
Compare
commented
Aug 16, 2019
Member
Author
|
Fixed @Trott doc nit. |
ronag
force-pushed
the
stream-no-error-after-error
branch
from
August 16, 2019 11:03
5c1fb91 to
2d36120
Compare
ronag
force-pushed
the
stream-no-error-after-error
branch
from
August 16, 2019 11:03
2d36120 to
dcec025
Compare
commented
Aug 17, 2019
Collaborator
commented
Aug 17, 2019
Member
|
Landed in 4a2bd69 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only emit
erroronce.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesNOTE TO SELF: After merge, look into emit in nextTick. Look into prefinish & nextTick.