Skip to content

Refactor util._extend to Object.assign #4838

New issue
New issue
Closed
Closed
Refactor util._extend to Object.assign#4838
Labels
duplicateIssues and PRs that are duplicates of other issues or PRs.utilIssues and PRs related to the built-in util module.

Description

@benjamingr
benjamingr
opened on Jan 24, 2016

Hey, I figured we can change util._extend to Object.assign in various places and replace util._extend itself with Object.assign.

As this is a small (but breaking) change for edge cases I figured I'd bring it up for discussion first.

The only difference is that assign copies symbols as well - I don't think it'll cause any issues.

Activity

  1. cjihrig commented on Jan 24, 2016

    @cjihrig
    cjihrig
    on Jan 24, 2016
    Contributor

    See #4593

  2. benjamingr commented on Jan 24, 2016

    @benjamingr
    benjamingr
    on Jan 24, 2016
    MemberAuthor

    Thanks! Looks like the discussion is already happening there.

  3. benjamingr
    closed this as completedon Jan 24, 2016
  4. r-52
    added
    utilIssues and PRs related to the built-in util module.
    on Jan 24, 2016
  5. mscdex
    added
    duplicateIssues and PRs that are duplicates of other issues or PRs.
    on Jan 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    duplicateIssues and PRs that are duplicates of other issues or PRs.utilIssues and PRs related to the built-in util module.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions