Skip to content

Breakpoint trap error in mksnapshot while building debug on ARM64 #15395

New issue
New issue
Closed
Closed
Breakpoint trap error in mksnapshot while building debug on ARM64#15395
Labels
armIssues and PRs related to the ARM architecture.buildIssues and PRs related to Node.js builds or CI infrastructure.v8 engineIssues and PRs related to the V8 dependency.

Description

@sgallagher
sgallagher
opened on Sep 13, 2017

I am attempting to build the 8.5.0 release for Fedora. The Fedora build system compiles Node.js for aarch64, armv7hl, i686, ppc64, ppc64le and x86_64. We build both the release and debug builds of Node.js, renaming /usr/bin/node to /usr/bin/node_g for the debug version.

Starting with 8.5.0, the aarch64/arm64 build is failing consistently with the following error:

Unknown external reference 0xffffabd9f660.
/lib64/libc.so.6(_IO_printf+0) [0xffffabd9f660]/bin/sh: line 1: 18877 Trace/breakpoint trap   (core dumped) "/builddir/build/BUILD/node-v8.5.0/out/Debug/mksnapshot" --startup_src "/builddir/build/BUILD/node-v8.5.0/out/Debug/obj.target/v8_snapshot/geni/snapshot.cc" ""
rm fbe1a9e9a18b0df71caa3937d0fe023e7b86bff8.intermediate
make[1]: *** [deps/v8/src/v8_snapshot.target.mk:13: /builddir/build/BUILD/node-v8.5.0/out/Debug/obj.target/v8_snapshot/geni/snapshot.cc] Error 133
make: *** [Makefile:80: node_g] Error 2
make: *** Waiting for unfinished jobs....

The complete logs of this build are available at https://kojipkgs.fedoraproject.org//work/tasks/4653/21844653/build.log (note that they are running on a 16-thread parallel make invocation, so things are a little out of order).

For the time being, I'm going to skip building the debug binary on aarch64, but some help tracking down the issue would be most appreciated.

Activity

  1. sgallagher
    changed the title [-]Breakpoint trap error on ARM64 in mksnapshot while building debug on ARM64[/-] [+]Breakpoint trap error in mksnapshot while building debug on ARM64[/+] on Sep 13, 2017
  2. mscdex
    added
    armIssues and PRs related to the ARM architecture.
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    v8 engineIssues and PRs related to the V8 dependency.
    v8.x
    on Sep 13, 2017

  3. bnoordhuis commented on Sep 18, 2017

    @bnoordhuis
    bnoordhuis
    on Sep 18, 2017
    Member

    I'm reasonably sure it's caused by https://github.com/nodejs/node/blob/v8.5.0/deps/v8/src/arm64/macro-assembler-arm64.cc#L4372 - V8 tries to store a pointer to the printf() function from libc in the snapshot (the core dump of the runtime.)

    Does this patch sidestep the issue? Failing that, does commenting out that line help?

    diff --git a/deps/v8/src/v8.gyp b/deps/v8/src/v8.gyp
index e6e4567880..f70a427d54 100644
--- a/deps/v8/src/v8.gyp
+++ b/deps/v8/src/v8.gyp
@@ -350,7 +350,7 @@
             '<(INTERMEDIATE_DIR)/snapshot.cc',
           ],
           'variables': {
-            'mksnapshot_flags': [],
+            'mksnapshot_flags': ['--nodebug_code'],
             'conditions': [
               ['v8_random_seed!=0', {
                 'mksnapshot_flags': ['--random-seed', '<(v8_random_seed)'],
@@ -451,7 +451,7 @@
                 '<(mksnapshot_exec)',
               ],
               'variables': {
-                'mksnapshot_flags': [],
+                'mksnapshot_flags': ['--nodebug_code'],
                 'conditions': [
                   ['v8_random_seed!=0', {
                     'mksnapshot_flags': ['--random-seed', '<(v8_random_seed)'],

  4. sgallagher commented on Sep 19, 2017

    @sgallagher
    sgallagher
    on Sep 19, 2017
    ContributorAuthor

    I can confirm that the patch above allows the debug build to complete successfully: https://koji.fedoraproject.org/koji/taskinfo?taskID=21968956

  5. bnoordhuis commented on Sep 20, 2017

    @bnoordhuis
    bnoordhuis
    on Sep 20, 2017
    Member

    Happy to hear that. Can I ask you to file a bug report over at https://bugs.chromium.org/p/v8/issues/list? This code is not directly under our control.

  6. bnoordhuis commented on Oct 15, 2017

    @bnoordhuis
    bnoordhuis
    on Oct 15, 2017
    Member

    I'll go ahead and close this out. @sgallagher If you opened a V8 issue, can you post the link here? Thanks.

  7. bnoordhuis
    closed this as completedon Oct 15, 2017

  8. sgallagher commented on Oct 16, 2017

    @sgallagher
    sgallagher
    on Oct 16, 2017
    ContributorAuthor

    @bnoordhuis Sorry, I've had that on my TODO list for weeks and I kept forgetting to file it. I've just done so: https://bugs.chromium.org/p/v8/issues/detail?id=6939

  9. hashseed commented on Oct 17, 2017

    @hashseed
    hashseed
    on Oct 17, 2017
    Member

    This actually seems like an assertion in generated code fired. The patch being provided simply turns off debug-mode assertions. I don't think that should be the fix.

  10. planglois commented on Oct 24, 2017

    @planglois
    planglois
    on Oct 24, 2017

    Hello, we've now merged a fix for this, you should be able to enable assertions inside the snapshot now! Should the patch be cherry-picked for node?

  11. bnoordhuis commented on Oct 24, 2017

    @bnoordhuis
    bnoordhuis
    on Oct 24, 2017
    Member

    @planglois If the fix is back-ported to 6.2, we'll pick it up automatically. If not, we can float it if you open a pull request. 801e61a is an example of what back-ports in our tree look like.

  12. hguemar
    added a commit that references this issue on Jan 17, 2018

    Disable debug builds on aarch64 due to nodejs/node#15395

    6b6a25e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    armIssues and PRs related to the ARM architecture.buildIssues and PRs related to Node.js builds or CI infrastructure.v8 engineIssues and PRs related to the V8 dependency.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions