Skip to content

refactor: use ms instead of humanize-ms - #54

Closed
marswong wants to merge 1 commit into
node-modules:masterfrom
marswong:master
Closed

marswong wants to merge 1 commit into
node-modules:masterfrom
marswong:master

Conversation

@marswong

Copy link
Copy Markdown

No description provided.

@codecov-io

codecov-io commented Jan 11, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #54   +/-   ##
=======================================
  Coverage   93.47%   93.47%           
=======================================
  Files           4        4           
  Lines         276      276           
=======================================
  Hits          258      258           
  Misses         18       18
Impacted Files Coverage Δ
lib/agent.js 95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c46df1...c8d4daf. Read the comment docs.

@fengmk2

fengmk2 commented Oct 20, 2018

Copy link
Copy Markdown
Member

No, we use humanize-ms to support 5s and 5000 both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants