Repository navigation
Conversation
fhgffy
marked this pull request as ready for review
October 4, 2026 19:39
Author
|
The two Win32 XZ failures also occur in base build 54833985 at 88b98af, using the same VS 2019/MSVC 19.29 and liblzma 5.8.1 environment as this PR's build. All 194 shared test outcomes match; the three added tests pass. The ARM Windows and ARM UWP jobs fail during configuration because Windows SDK 10.0.26100.0 ARM support is missing, before libzip is compiled. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading an added or replaced
zip_source_bufferentry after settingZIP_CM_DEFLATE, but beforezip_close(), fails with a Zlib data error. The read pipeline uses the pending output compression method even though the source still contains uncompressed bytes.For changed entries, obtain the compression method, compressed size and their validity bits from the underlying source when preparing the read pipeline. Keep the public
zip_stat_index()metadata and the other entry attributes. Add regressions for new and replaced buffers, partial and repeated reads, and empty data.Validation on
88b98af764442d6de1b38a26bee5e6f6a33c2c67:ZIP_ER_INTERNALfrom close after the discarded read reportsZIP_ER_ZIPCLOSED.git diff --checkpasses.Testing used Windows x64, MinGW GCC 15.1, a Debug/static build, zlib and Windows crypto. Optional bzip2/LZMA/XZ/Zstd features were disabled. The complete configured suite was previously run on
05487938a72b47fa783df5b4dabe0869edc51ebc(181 passed, 16 skipped); this newer base received the focused validation above. Linux, ARM, MSVC, sanitizers and continuous fuzzing were not run. Ordinary-file and add-from-zip sources retain their existing changed-read rejection; custom compressed sources supporting REOPEN were not covered.