Skip to content

fix: calendar subscription transparency - #66508

Open
SebastianKrupinski wants to merge 1 commit into
masterfrom
fix/calendar-subscription-transparancy
Open

SebastianKrupinski wants to merge 1 commit into
masterfrom
fix/calendar-subscription-transparancy

Conversation

@SebastianKrupinski

@SebastianKrupinski SebastianKrupinski commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Resolves: # Client Ticket
  • Added migration to allow setting subscription calendar transparency
  • Added transparency interface for calendars to implement
  • Modified all relevant files to include calendar subscriptions in free/busy

Testing

  • Add calendar subscription with events that have a opaque transparency, open free/busy to see if the subscription events show time slots as busy

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@SebastianKrupinski

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@SebastianKrupinski

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@SebastianKrupinski

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@SebastianKrupinski SebastianKrupinski added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 10, 2026
@SebastianKrupinski
SebastianKrupinski marked this pull request as ready for review November 10, 2026 17:36
@SebastianKrupinski
SebastianKrupinski requested review from CarlSchwan and leftybournes and removed request for a team November 10, 2026 17:36

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is AI assisted but lacks the commit trailer

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document why this is added and how it can be tested. Right now I don't see how this is a fix that needs backporting.

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Assisted-by: ClaudeCode:claude-opus-5-5
@SebastianKrupinski

Copy link
Copy Markdown
Contributor Author

Document why this is added and how it can be tested. Right now I don't see how this is a fix that needs backporting.

We discussed this, this morning. I've added testing instructions

@ChristophWurst

ChristophWurst commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Discussing in a call is not documentation. There are three other reviewers who have no chance of understanding the context of this change.

We discussed how subscriptions should be handled in free/busy and the decision was to make the transparency an option. This is pretty much a new feature. I do not see a strong reason why this needs to be backported.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🏗️ In progress

Development

Successfully merging this pull request may close these issues.

3 participants