Repository navigation
[stable33] fix(federation): compare tokens in the shared secret job - #66418
Open
backportbot[bot] wants to merge 1 commit into
Open
backportbot[bot] wants to merge 1 commit into
backportbot[bot] wants to merge 1 commit into
Conversation
When both servers start the shared secret exchange, the one with the greater token asks for the secret. Do this check in the GetSharedSecret job instead of the request handler, so the handler only checks the server and queues the job. Tokens are generated with 16 characters, so refuse anything longer than 64. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
susnux
force-pushed
the
backport/66359/stable33
branch
from
November 6, 2026 20:09
4e9b823 to
874b6c7
Compare
susnux
marked this pull request as ready for review
November 6, 2026 20:09
susnux
requested review from
leftybournes and
provokateurin
and removed request for
a team
November 6, 2026 20:09
susnux
approved these changes
Nov 6, 2026
This was referenced Nov 10, 2026
Merged
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #66359
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.