Repository navigation
[stable33] fix(theming): only accept canonical svg paths for themed icons - #66312
Merged
Merged
Conversation
The themed icon cache key was derived from the raw image path while the lookup in Util::getAppImage() strips ".." and tries additional extensions. This allowed many spellings of the same file (including non-svg images) to each create a separate cache entry. Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-VGIZP3VV Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
backportbot
Bot
requested review from
DerDreschner,
leftybournes,
provokateurin,
susnux and
szaimen
and removed request for
a team
November 4, 2026 16:28
susnux
approved these changes
Nov 4, 2026
AndyScherzinger
approved these changes
Nov 4, 2026
Contributor
|
This pull request has been automatically locked because it has been closed for more than 7 days. As we do not monitor merged or closed pull requests, we are locking this pull request to prevent further comments from getting lost in the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #66285