Repository navigation
[stable33] fix: Use POST instead of GET for multi-file downloads - #66287
Open
backportbot[bot] wants to merge 3 commits into
Open
backportbot[bot] wants to merge 3 commits into
backportbot[bot] wants to merge 3 commits into
Conversation
When downloading multiple files as a ZIP archive, filenames were appended to the URL as query parameters, causing "414 Request-URI Too Long" errors with many files. Backend now supports POST requests with files in request body. Frontend sends files via FormData in POST body instead of URL params. Fixes #7935 Signed-off-by: nfebe <fenn25.fn@gmail.com>
Downloading the archive through axios as a blob buffered the whole archive in memory and then failed, as HEAD requests on blob URLs are not allowed. Submit a hidden form instead so the browser streams the download natively. Also reject non-string `files` parameters instead of failing with a TypeError. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
backport/56543/stable33
branch
from
November 4, 2026 13:16
3e46288 to
d679b3f
Compare
CarlSchwan
marked this pull request as ready for review
November 4, 2026 13:16
CarlSchwan
requested review from
icewind1991,
kristian-zendato,
provokateurin and
susnux
and removed request for
a team
November 4, 2026 13:16
Contributor
|
Should go to master first, and then needs to be backported to 35 and 34 as well otherwise you unpatch by updating |
This was referenced Nov 4, 2026
Merged
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #56543
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.