[lazerg]

• Resolves: [Bug]: Detection::detectString() / detectContent() never use finfo – missing use finfo; (regression from #54077) #66239

Summary

Detection.php lives in OC\Files\Type but never imported finfo, so class_exists(finfo::class) checked OC\Files\Type\finfo and was always false. detectString() then fell back to the temp file path, where getSecureMimeType() turned types like image/vnd.microsoft.icon into application/octet-stream. Adding use finfo; brings back the finfo path from before #54077. I also added a test that runs detectString() on an .ico file.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

• The content of this PR was partly or fully generated using AI

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[susnux]

/backport to stable35

[github-actions]

This pull request has been automatically locked because it has been closed for more than 7 days. As we do not monitor merged or closed pull requests, we are locking this pull request to prevent further comments from getting lost in the noise.
If you discovered any issues with this pull request, please open a new issue instead. In case you want to discuss this pull request or have further questions, please use our forum: https://help.nextcloud.com