Repository navigation
fix(files): update cached mounts when their storage changes - #66184
ArtificialOwl wants to merge 1 commit into
Conversation
Signed-off-by: Maxence Lange <maxence@artificial-owl.com> Assisted-by: ClaudeCode:claude-opus-5-5
provokateurin
left a comment
There was a problem hiding this comment.
Shouldn't the storage id for Bob not change, because he only sees the file through the SharedStorage?
| if ( | ||
| $newMount->getMountId() !== $cachedMount->getMountId() | ||
| || $newMount->getMountProvider() !== $cachedMount->getMountProvider() | ||
| || $newMount->getStorageId() !== $cachedMount->getStorageId() |
There was a problem hiding this comment.
The use of findChangedMounts doesn't expect the storage id for a mount to change, so there will be problems.
The file is not on the previous storage id anymore; while moving from Maybe a better fix would be to catch the wrongly cached mount and try to fix the cache ? |
|
I will ping Robin regarding #59900 when he's back |
AI (if applicable)