Repository navigation
[stable35] fix(files): keep the view when reloading a file opened outside the files view - #65543
Open
backportbot[bot] wants to merge 1 commit into
Open
backportbot[bot] wants to merge 1 commit into
backportbot[bot] wants to merge 1 commit into
Conversation
…les view Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
backportbot
Bot
added
bug
3. to review
Merged
susnux
requested changes
Nov 5, 2026
susnux
left a comment
susnux
left a comment
Contributor
There was a problem hiding this comment.
CI related, needs adjustments for 35 and before:
There were
4 errors:
- OCA\Files\Tests\Controller\ViewControllerTest::testRedirectToFileFolder with data set "files view" ('files', true)
PHPUnit\Framework\MockObject\Generator\UnknownTypeException: Class or interface "OCA\Files\Tests\Controller\IUserFolder" does not exist/home/runner/actions-runner/_work/server/server/apps/files/tests/Controller/ViewControllerTest.php:228
- OCA\Files\Tests\Controller\ViewControllerTest::testRedirectToFileFolder with data set "no view" ('', true)
PHPUnit\Framework\MockObject\Generator\UnknownTypeException: Class or interface "OCA\Files\Tests\Controller\IUserFolder" does not exist/home/runner/actions-runner/_work/server/server/apps/files/tests/Controller/ViewControllerTest.php:228
- OCA\Files\Tests\Controller\ViewControllerTest::testRedirectToFileFolder with data set "personal files" ('personal', true)
PHPUnit\Framework\MockObject\Generator\UnknownTypeException: Class or interface "OCA\Files\Tests\Controller\IUserFolder" does not exist/home/runner/actions-runner/_work/server/server/apps/files/tests/Controller/ViewControllerTest.php:228
- OCA\Files\Tests\Controller\ViewControllerTest::testRedirectToFileFolder with data set "tags view" ('tags', false)
PHPUnit\Framework\MockObject\Generator\UnknownTypeException: Class or interface "OCA\Files\Tests\Controller\IUserFolder" does not exist/home/runner/actions-runner/_work/server/server/apps/files/tests/Controller/ViewControllerTest.php:228
| $node->method('getPath')->willReturn('/testuser1/files/Folder/photo.jpg'); | ||
| $node->method('getParent')->willReturn($this->createMock(Folder::class)); | ||
|
|
||
| $baseFolderFiles = $this->createMock(IUserFolder::class); |
Contributor
There was a problem hiding this comment.
36+ only, does not exist on stable35
This was referenced Nov 10, 2026
Merged
Merged
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #65120