Repository navigation
[stable35] fix(core): explicitly list emitted event and use proper component props - #64993
Open
backportbot[bot] wants to merge 3 commits into
Open
backportbot[bot] wants to merge 3 commits into
backportbot[bot] wants to merge 3 commits into
Conversation
The teardown was declared as `beforeUnmount`, a hook Vue 2 does not know, so it never ran: the hover timers kept firing after the menu was gone and the `nextcloud:app-menu.refresh` subscription and the popover listener were never removed. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Assisted-by: ClaudeCode:claude-opus-5-5
Several components were given props the nextcloud-vue components do not declare, so they ended up as plain attributes or were dropped: - the login note cards passed their heading as `title`, and once as `class`, so the heading was never rendered - the empty contents of the legacy search passed their name as `title` - the account menu avatar used `hide-user-status`, so the status was shown even when the user status app provides none - the password field set `spellchecking` instead of the native `spellcheck` - the updater misspelled `aria-controls` - `hideFavorite`, `clear-view-delay`, a duplicated modal `title` and the button `loading` of the installer did nothing and are removed Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Assisted-by: ClaudeCode:claude-opus-5-5
backportbot
Bot
requested review from
CarlSchwan,
skjnldsv,
susnux and
szaimen
October 1, 2026 16:05
Ten components emitted events without declaring them. Vue 2 does not care, but Vue 3 also passes an undeclared listener on to the root element, so a component that re-emits the click of a clickable root would trigger its parent's handler twice. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Assisted-by: ClaudeCode:claude-opus-5-5
susnux
force-pushed
the
backport/64984/stable35
branch
from
November 6, 2026 16:16
cc842ba to
2db008d
Compare
susnux
marked this pull request as ready for review
November 6, 2026 16:16
susnux
approved these changes
Nov 6, 2026
This was referenced Nov 10, 2026
Merged
Merged
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #64984
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.