Skip to content

fix: improve invitation mail building - #64942

Open
SebastianKrupinski wants to merge 1 commit into
masterfrom
fix/improve-invitation-mail-building
Open

SebastianKrupinski wants to merge 1 commit into
masterfrom
fix/improve-invitation-mail-building

Conversation

@SebastianKrupinski

@SebastianKrupinski SebastianKrupinski commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • This is more of a refactor but i'm framing it as a fix so it can be back ported

  • Moved all mail building functionality in to iMipService

  • Split mail building in to 3 distinct methods one for each type "Request, Reply, Cancel"

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@SebastianKrupinski

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@SebastianKrupinski
SebastianKrupinski requested a review from a team as a code owner October 29, 2026 14:49
@SebastianKrupinski
SebastianKrupinski requested review from Altahrim, come-nc, leftybournes and salmart-dev and removed request for a team October 29, 2026 14:49
@SebastianKrupinski
SebastianKrupinski force-pushed the fix/improve-invitation-mail-building branch from 4a95088 to 1721045 Compare October 29, 2026 14:58
Base automatically changed from fix/event-instance-paring to master October 29, 2026 16:09
@SebastianKrupinski
SebastianKrupinski force-pushed the fix/improve-invitation-mail-building branch from 1721045 to ede158c Compare October 29, 2026 16:09
@alphadawn

Copy link
Copy Markdown

Hi @SebastianKrupinski i would like to ask when the updated version would be released (for nextcloud version 35 stable), since we really need the fix to this problem to be out as soon as possible for us to work with events in the calendar in our organization.

@DerDreschner
DerDreschner force-pushed the fix/improve-invitation-mail-building branch from ede158c to 8542bd6 Compare November 10, 2026 15:35
@SebastianKrupinski SebastianKrupinski added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 10, 2026
@SebastianKrupinski
SebastianKrupinski force-pushed the fix/improve-invitation-mail-building branch from 8542bd6 to 7a8f25c Compare November 10, 2026 23:46
@SebastianKrupinski

Copy link
Copy Markdown
Contributor Author

Hi @SebastianKrupinski i would like to ask when the updated version would be released (for nextcloud version 35 stable), since we really need the fix to this problem to be out as soon as possible for us to work with events in the calendar in our organization.

Hi @alphadawn

What problem are you referring to? This does not fix an issue at the moment. It's just a restructure of some code so that I can build improvements on top of it

@alphadawn

alphadawn commented Nov 11, 2026 •

Copy link
Copy Markdown

hi @SebastianKrupinski, The problem we are facing in our orginazation right now is that when someone on nextcloud recives an invite to an event from outside of nextcloud (say Outlook) and this person accepts/rejects the invite, the person on outlook does not recive the acception/rejection email, and thus does not know what the answer of the recipiant is. invites from Nextcloud -> Nextcloud work and the acception/rejection Email does in fact get sent. i suspect this being because of how Outlook sends the .ics file, since Outlook encodes it in base64 and sends it in the email itself instead of sending it as a separate .ics attachment like how Nextcloud does it.

@alphadawn

Copy link
Copy Markdown

i have made a bug report here and have also added a suggested fix to the problem that i have made today

@SebastianKrupinski

Copy link
Copy Markdown
Contributor Author

hi @SebastianKrupinski, The problem we are facing in our orginazation right now is that when someone on nextcloud recives an invite to an event from outside of nextcloud (say Outlook) and this person accepts/rejects the invite, the person on outlook does not recive the acception/rejection email, and thus does not know what the answer of the recipiant is. invites from Nextcloud -> Nextcloud work and the acception/rejection Email does in fact get sent. i suspect this being because of how Outlook sends the .ics file, since Outlook encodes it in base64 and sends it in the email itself instead of sending it as a separate .ics attachment like how Nextcloud does it.

Okay, that is not this PR, I believe this is already fixed in a different PR

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski
SebastianKrupinski force-pushed the fix/improve-invitation-mail-building branch from 7a8f25c to dc0cd09 Compare November 12, 2026 00:27

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish backport-request

Projects

Status: 🏗️ In progress

Development

Successfully merging this pull request may close these issues.

4 participants