Skip to content

fix(e2ee): compare certificate keys and explain verification failures - #18004

Open
xO-ox-ai wants to merge 1 commit into
nextcloud:masterfrom
xO-ox-ai:fix/e2ee-certificate-validation
Open

xO-ox-ai wants to merge 1 commit into
nextcloud:masterfrom
xO-ox-ai:fix/e2ee-certificate-validation

Conversation

@xO-ox-ai

Copy link
Copy Markdown

Fix E2EE certificate comparison so that a renewed certificate containing the same public key is not incorrectly treated as a key change. Certificate validity, server signature, and local private key matching are checked before updating the cached certificate.

Replace the generic “Failed to verify public key” message with specific failure reasons and suggested next steps, displayed in a dialog.

All 21 new regression tests pass. Compilation, Android lint, and formatting checks pass. The full test suite has 32 failures in other modules on Windows; SpotBugs could not start because of the Windows command length limit. Device and server integration testing has not been performed.

Developed with assistance from OpenAI Codex (GPT-6.1 sol).^_^

Assisted-by: Codex:GPT-6.1 sol
Signed-off-by: Li Wei <caeser222000@sohu.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant