Skip to content

fix(file-data-storage-manager): operations - #17941

Merged
alperozturk96 merged 4 commits into
masterfrom
fix/file-data-storage-manager-operations
Nov 3, 2026
Merged

alperozturk96 merged 4 commits into
masterfrom
fix/file-data-storage-manager-operations

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Changes

  • Uses DAO functions
  • The provider query no longer appends AND null, so deleting a folder removes its children at every depth.
  • deleteAllFiles() deletes only by file_owner. The provider's folder delete without an id now respects where.
  • adds tests

How to test?

  • Have folders in root and delete a folder web and refresh from client, it should refresh correctly
  • Have a nested folder hierarchy and delete folder all child files must be removed.

check via app inspection

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the fix/file-data-storage-manager-operations branch from 2256c7a to 8ad26c9 Compare November 3, 2026 10:58
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit e5d38cf
Version 17941
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

@alperozturk96 alperozturk96 linked an issue Nov 3, 2026 that may be closed by this pull request
4 tasks done
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4545
Dodgy code145145
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2828
Security1515
Total272272

@alperozturk96
alperozturk96 merged commit caf6c2c into master Nov 3, 2026
27 of 28 checks passed
@alperozturk96
alperozturk96 deleted the fix/file-data-storage-manager-operations branch November 3, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

two-way sync is repeatedly downloading files over and over

2 participants