Repository navigation
Fix uniqueItems validation for non-array inputs - #1297
Conversation
|
Code review(xhigh · 5 findings) PR #1297 is correct and ready to merge from a correctness standpoint. I found no bugs in the change and reported 5 findings: one existing behaviour you might want fixed alongside it, and four about the tests. That's below the usual floor of 7 because I didn't find more real issues. The fix: the one-line node.isArray() guard fixes #1294.
Verification:
Findings:
None of these blocks merging. If you want one change requested, I'd pick finding 2: relax or drop that test so the duplicate-error cleanup stays easy later. |
|
Thanks for the review. I removed the test that fixed the duplicate-error count and the assertion that ran These updates are included in both #1297 and #1298. All 50 cases in |
|
Code review(xhigh · 5 findings) The author's update (4ebf40b) fixes 3 of our 5 findings and adds no new problems. My sweep of the changed code found nothing new to report. Resolved
Still open
What I ran
The PR is ready to merge. I haven't posted anything on GitHub. Do you want me to add a follow-up comment on #1297 (and #1298) acknowledging the fixes and noting the loop nit as optional? |
Fixes #1294. The
2.xcounterpart is #1298.Only run
uniqueItemsvalidation for arrays so repeated object property values do not produce duplicate-item errors.Regression tests cover all five supported drafts, including
not, bothoneOfoutcomes, nested properties, andwalk. Existing array comparisons and duplicate-error counts are unchanged.Validation:
mvn verifyon Java 17: 8,693 tests, 0 failures/errors, 30 skipped.UniqueItemsApplicabilityTestrun after test naming and formatting cleanup: 50 tests passed.