Skip to content

Avoid regexp_parser 2.13.2 in the development bundle - #689

Merged
koic merged 1 commit into
modelcontextprotocol:mainfrom
koic:avoid_regexp_parser_2_13_2_in_the_development_bundle
Nov 17, 2026
Merged

koic merged 1 commit into
modelcontextprotocol:mainfrom
koic:avoid_regexp_parser_2_13_2_in_the_development_bundle

Conversation

@koic

@koic koic commented Nov 17, 2026

Copy link
Copy Markdown
Member

Motivation and Context

regexp_parser 2.13.2, released on 2026-11-16, makes Regexp::Syntax::Base.implements private (ammar/regexp_parser#116). json_schemer 2.5.0 calls it on a subclass when it is required (davishmcclurg/json_schemer#238), so require "mcp" raises NoMethodError and bundle exec rake aborts while loading the tests. No lockfile is committed, and both json_schemer (~> 2.0) and RuboCop (>= 2.11.3, < 3.0) admit 2.13.2, so a fresh bundle install, CI included, resolves it.

The Gemfile now excludes that one version, as it already does for i18n 1.15.0, so a release that restores the method is picked up without another change. The gemspec is left as it is: this covers development and CI only.

How Has This Been Tested?

bundle exec rake aborts in the test task with regexp_parser 2.13.2 installed, and resolves 2.13.1 and passes with the exclusion.

Breaking Changes

None.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

## Motivation and Context

regexp_parser 2.13.2, released on 2026-11-16, makes `Regexp::Syntax::Base.implements` private (ammar/regexp_parser#116).
json_schemer 2.5.0 calls it on a subclass when it is required (davishmcclurg/json_schemer#238), so `require "mcp"` raises
`NoMethodError` and `bundle exec rake` aborts while loading the tests. No lockfile is committed, and both json_schemer
(`~> 2.0`) and RuboCop (`>= 2.11.3, < 3.0`) admit 2.13.2, so a fresh `bundle install`, CI included, resolves it.

The Gemfile now excludes that one version, as it already does for i18n 1.15.0, so a release that restores the method
is picked up without another change. The gemspec is left as it is: this covers development and CI only.

## How Has This Been Tested?

`bundle exec rake` aborts in the test task with regexp_parser 2.13.2 installed, and resolves 2.13.1 and passes with
the exclusion.

## Breaking Changes

None.
@koic
koic merged commit 41c28a8 into modelcontextprotocol:main Nov 17, 2026
13 checks passed
@koic
koic deleted the avoid_regexp_parser_2_13_2_in_the_development_bundle branch November 17, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant