Repository navigation
Migrate Sites shared directives and validate both v3 profiles - #3903
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 17 commits into
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 17 commits into
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 17 commits into
Conversation
Repair the authorized unmatched terminal parenthesis while retaining the invalid original. Audit both actual legacy profiles and preserve exact compatible route successors, existing curated behavior, structural naming and deferred scopes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full compatible-spec pipeline with Kiota 1.36.1 and Authentication 2.38.1: Release OK, 1092 exports. Kiota source and generated projects are byte-identical; retain the generated client lock update together with all cmdlet changes. Migrated compiled routes and ten unaffected neighbors pass; baseline parity limitations remain explicit. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Pin all 84 Learn Default parameter sets and unique actual mandatory-ID contracts; all default to Direct, correcting 60 misleading first-URI metadata candidates. Preserve exact legacy/current identities for all 192 live routes and prove matching body, response and nonpath parameter contracts. Record evidence only: do not activate unmerged multi-route APIs or prune routes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Prove all 24 actual structural list/item pairs and all mandatory-ID contracts. Retain ordinary no-selector dispatch for 78 groups; only six DirectGet/NestedList collisions require explicit asymmetric selection and published parameter inference. Evidence and tests only until the shared API merges normally. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use three-setting GeneratorConfig and separate runtime profiles with derived data on/off. Prove complete196/227 original-selector survivors equal aligned current literal sets; keep lineage in audit/tests without unmerged helper schema. Preserve direct-tree published defaults and all recursive URLs through exact source-backed NestedChild names rather than obsolete route selectors or mutation merges. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Final shared source05a10b3d73; prescribed queued full compatible Kiota1.36.1 and cmdlet Release pipeline passed exit0 StatusOK in42.9s with1100exports. Fresh full module verified201suppression rows,11rename rows,10neighbors,19actual no-session dispatches and96recursive routes with96frozen derived suppressions. Combined client,cmdlet,project,lock output only; no binaries/logs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Final shared source05a10b3d73; prescribed sequential queued full compatible Kiota1.36.1 and cmdlet Release pipeline passed exit0 StatusOK in76.1s with1397exports. Fresh full module verified233suppression rows,11rename rows,10neighbors,19no-session dispatches and all192recursive/direct routes;120actual GET/count HTTPrequests preserve exact URLs/defaults. Real typed POST remains blocked by unmerged#3878 missingRMS packaging; no body/refetch or all-surface parity pass claimed. Preserve exact Kiota-generated whitespace rather than manufacture formatting deltas. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Exercise actual x-ms-docs operation metadata and matching GET/function or POST/action methods for every final-qualification bridge, plus unique current normalized method/path identities. Test-only strengthening; production source and both full generation runs remain final-source05a10b3d73. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Record normally merged844672d7 target. Existing196/227 literal source-survivor ledger and profile-neutral NestedChild configuration unchanged; oldAuth/candidateproof remains historical. CurrentTRX/strictgates passed before newfullprofilegeneration. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fullqueuedfinalsource0959c219c1 on normallymerged844672d7: exit0OK1100exports93.6s with adaptednormalAuth2.41.2 andKiota1.36.1cap1. Freshmanifest3ownedDLLs/nopreloads,allmigrated/recursive/default/neighborroutes verified. Real12POST/12typedPATCH/12PATCH204refetch/12DELETE pass; requiredrefetchHeaders12losses reproduceunmerged3886,notruntimeacceptance/PRpass. PreservecombinedKiotaclient+cmdlets+projects+locks boundary; noDLLs/logs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sequentialfullqueuedfinalsource0959c219c1 on normallymerged844672d7: exit0OK1397exports105s withadaptednormalAuth2.41.2/Kiota1.36.1cap1. Freshmanifest3ownedDLLs/nopreloads;all192recursiveURLs andreal120GET/countrequests assertbeta notv1.0. Real24POSTJSON24typedPATCH24PATCH204sameURLGETrefetch24DELETE72WhatIf72decline120binderchecks pass except24requiredrefetch-Headers losses: reproduceunmerged3886,notruntimeacceptanceorPRpass. Combinedclient+cmdlets+projects+lockfiles,noDLLs/logs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add actualfullspec PATCH emission regression:204success has nooutput/readback,200returnsitsmodel,headers/ShouldProcess/profiletransport remain. Record finalnormallymerged6475 target and callerexplicitGET semantics withoutchanging sharedselectors/names/frozenroutes. ActualtargetedTRX189passed/0failed/0skipped;ordinarystrict13Mapped1Deferred. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fullnormal6475finalsourcead18c75b21:queuedKiota+cmdletsReleaseexit0OK1100exports758.6s. NonincrementalbuildPASSbinaryidentical. FreshGlobal/USGovtypedPATCH204onlyonePATCHnoobjectnoGET/PATCH200typedonePATCH plus independentGET200/403,allmigrated/default/neighborroutes,safety/clientcache/closure proofPASS. Combinedclient/cmdlet/project/lockboundary;byte-identicalclient/locksnofabricateddelta. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fullnormal6475finalsourcead18c75b21:sequentialqueuedKiota+cmdletsReleaseexit0OK1397exports225.3s. NonincrementalbuildPASSbinaryidentical. FreshGlobal/USGovrealFactoryAuthfullrecursive192routes/typedPATCH200and204NOGET/noobject/explicitGET200403/POSTDELETE/action/media/safety/profilecloudcacheproofPASS; no unnormalizedparitypassclaimed. Separatecombinedclient+cmdlet+project+lockboundary,byteidenticalclient/locksdonotmanufacturediff. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
requested a review
from a team
as a code owner
November 6, 2026 02:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N/A - directive migration; no linked issue.
Changes proposed in this pull request
src\Sites\Sites.mdcmdlet directives: 13 Mapped, 1 Deferred. Preserve active AutoRest source and full original-selector lineage: 196 v1.0 / 227 beta matches and identical exact surviving current operations, no fabricated removals. The authorized repair appends exactly one missing terminal); the invalid original and its undefined match set remain documented and tested.NestedChildnames for recursive/children/{id}/childrenoperations. All 192 beta recursive/direct operations remain reachable. Existing 96 frozen v1.0 omissions and 66 intentional surviving v1.0 nested-operation renames are explicit limits, not blanket parity success. No selector flags, new mutation groups, derived unsuppressions, global generator changes, or profile-specific authoring.6475f3f5beb4908d39ea356db32bf1e0fd3273cb; retain prior migration/history and separate combined Kiota client + cmdlet/project/lock commits per profile. PATCH 204 now succeeds with one PATCH, no object, and no GET; PATCH 200 returns its actual typed model from one PATCH. Caller-explicit GET is independent. Ignoresrc\readme.graph.mdand all profile-local directive files; parameter/default aliases/transforms and schema directives remain deferred. Supported profiles are exactly v1.0 and beta; excluded profiles: none.Final normal-target generation
dc1cbf6acf208001f43b353bbcfa68510936bb3d701adafe468170fc67fa4933d572838cff325ad6Normal integration:
92d7d28f89ad01345e3f7ab3d2c3d5c3a7653d80. Final authored source/test/doc correction:ad18c75b21ae7c8d61f2c7ae996d96e16c2a36f6. Earlier migration and generated boundaries are preserved; byte-identical regenerated client/project/lock files were not fabricated into diffs.Exact validation commands and outcomes
dotnet test .\tools\WrapperGenerator.Tests\WrapperGenerator.Tests.csproj --filter 'FullyQualifiedName~SitesDirectiveMigrationTests|FullyQualifiedName~NamingTests|FullyQualifiedName~CmdletConfiguratorTests|FullyQualifiedName~RequiredQueryTests|FullyQualifiedName~PatchOperationTests' --logger 'trx;LogFileName=targeted.trx' --results-directory 'C:\Users\ramsess\.copilot\session-state\03ade150-4c5d-499b-877f-09e79cbf681b\files\post3886-6475-final' --verbosity quiet— passed, 189 executed / 189 passed / 0 failed / 0 skipped; actualtargeted.trxretained.tools\Get-WrapperDirectiveMigrationInventory.ps1 -Module Sites -FailOnUnresolved— passed, 13 Mapped / 1 Deferred / 0 unresolved.pwsh -NoProfile -NonInteractive -File C:\Users\ramsess\.copilot\session-state\871a5292-dc5b-423e-8083-5165b0006603\files\Invoke-QueuedModuleBuild.ps1 -RepoRoot C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-super-barnacle -Module Sites -ApiVersion v1.0 -Configuration Release— passed, exit 0 / OK, 1100 exports in 758.6s.pwsh -NoProfile -NonInteractive -File C:\Users\ramsess\.copilot\session-state\871a5292-dc5b-423e-8083-5165b0006603\files\Invoke-QueuedModuleBuild.ps1 -RepoRoot C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-super-barnacle -Module Sites -ApiVersion beta -Configuration Release— passed, exit 0 / OK, 1397 exports in 225.3s.dotnet build src\Sites\wrapper\v1.0\Microsoft.Graph.Wrapper.Sites.csproj -c Release --no-incremental --nologo -v quietand the same command withbeta— passed after the complete full builds; no skipped Kiota or proxy builds used for generation acceptance.pwsh -NoProfile -NonInteractive -File "C:\Users\ramsess\.copilot\session-state\03ade150-4c5d-499b-877f-09e79cbf681b\files\post3886-6475-final\Test-SitesCompiled.ps1" -RepoRoot "C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-super-barnacle" -ApiVersion <v1.0|beta> -ExerciseDispatch— passed on each actual full module: exact exports, 201/233 suppression rows absent, 11 shared rename rows, 10 unaffected neighbors, 19 dispatch calls, 96/192 emitted recursive routes, unchanged frozen v1.0 suppressions, only three wrapper-owned DLLs and no dependency preloads.pwsh -NoProfile -NonInteractive -File "C:\Users\ramsess\.copilot\session-state\03ade150-4c5d-499b-877f-09e79cbf681b\files\post3886-6475-memory-final\Test-SitesHttp.ps1" -RepoRoot "C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-super-barnacle" -ApiVersion <v1.0|beta> -Environment <Global|USGov>— passed in all four combinations using real Connect-MgGraph + in-memory MockDataStore + GraphHttpClientFactory and offline terminal capture, no live Graph/OAuth. Each cloud verifies 12/24 POST JSON, 12/24 typed PATCH 200, 12/24 PATCH 204 with no output/no GET even when GET is denied, independent explicit GET 200/403, 12/24 bodyless DELETE, escaped IDs/headers/typed results, 36/72 WhatIf and genuine one-prompt declined confirmations, 60/120 binder failures before HTTP, all 60/120 recursive GET/count routes, query forwarding, cache reuse, request-context/reconnect/disconnect and correct cloud/profile URL without mutating the shared factory's global/v1.0 BaseAddress.pwsh -NoProfile -NonInteractive -File "C:\Users\ramsess\.copilot\session-state\03ade150-4c5d-499b-877f-09e79cbf681b\files\post3886-6475-memory-final\Test-SitesActionMedia.ps1" -RepoRoot "C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-super-barnacle" -ApiVersion <v1.0|beta> -Environment <Global|USGov>— passed in all four combinations: actual typed group-site add action, file-content PUT/typed return, media GET bytes/OutFile, escaped URLs/headers, WhatIf and two genuine single declined prompts with zero HTTP.dotnet run --project "C:\Users\ramsess\.copilot\session-state\03ade150-4c5d-499b-877f-09e79cbf681b\files\post3886-6475-final\audit\Audit.csproj" -- "C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-super-barnacle" "C:\Users\ramsess\.copilot\session-state\03ade150-4c5d-499b-877f-09e79cbf681b\files\post3886-6475-final"— passed, full actual-spec audit of 1,856 v1.0 and 1,560 beta operations found zero required query inputs. No mandatory Query-name gate was silently skipped; no optional query expansion was added.tools\Compare-WrapperCmdletNames.ps1 -GeneratedPath src\Sites\wrapper\<profile>\Cmdlets— exit 1, not a pass: v1.0 1,006/1,100 matches (82 mismatches / 12 no-oracle); beta 0/1,397 matches (1,273 mismatches / 124 no-oracle). Includes intentional distinct recursive names, lossy first-URI metadata, existing unsupported/client-only surfaces and the unnormalized Mg/MgBeta prefix difference. This PR does not broaden into a parity rewrite.Acceptance used PS7/Core, .NET 10.0.403, isolated Kiota
1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943with cap 1, and the normal-source-equivalent Authentication 2.41.2 package. All 64 Authentication file hashes and physical nupkg SHA2562FC09BFE6B70D313BC56DF8ADCCFB1976FB4E90A1898BF8A916B4B8B792898EBwere verified unchanged. Authentication owns the single Kiota/RMS/URI/Multipart closure; no wrapper copies, DLL shims, stock Gallery substitutions, or dependency preloads. Existing NU1903 YamlReader warning is retained. Offline behavior proof is not tenant/API certification; Desktop/5.1 is not an acceptance claim.Compatible spec blobs: v1.0
bfe16a5f7a10b5f27a2aa39cb280932928833956; beta6151f3730d4a4d985416bff420d382499b5456be.Current canonical evidence and exact raw logs/exit metadata/TRX/HTTP captures/manifests/assembly hashes/full Git scope:
C:\Users\ramsess\.copilot\session-state\03ade150-4c5d-499b-877f-09e79cbf681b\files\post3886-6475-memory-final\handoff.json. Earlier failed-header/candidate reports remain immutable historical evidence; they were not relabeled as passes. No artifacts, binaries, bin/obj, packages, or logs are committed.Probe-only datastore isolation correction (same head; no rebuild/source change): Normal module imports into the additional confirmation runspace can reset the shared GraphSession datastore. The corrected eight fresh runtime/media runs reapply the existing
Set-MgTestDataStorehelper after the last additional-runspace import and before Connect, then assert and record the actual reflectedGraphSession.DataStore.GetType().FullNameasMicrosoft.Graph.Authentication.Test.Mocks.MockDataStorebefore transport, confirmations, lifecycle and logout. All 1674 phase guards and 830 actual HTTP capture guards passed with that exact type. Corrected commands above usepost3886-6475-memory-final; original full-build logs/TRX/source/generation/manifests remain valid and unchanged at their original paths. Earlier runtime evidence and the old handoff remain immutable historical proof without the new post-import isolation claim; a DiskDataStore type by itself is not evidence that credential I/O occurred. No Authentication/package/loader changes, DLL injection, full-build reruns, generation commits, new PR, or change to the positive PATCH contract were made. Exact guard/type/capture evidence is indexed in the new canonical handoff.Other links
6475f3f5beb4908d39ea356db32bf1e0fd3273cb).src\Sites\wrapper\Sites_directiveMigrationMap.jsonandSites_multiRouteEvidence.json.