Repository navigation
fix(form): preserve whitespace in field names - #893
Open
Muneer Alam (Muneer320) wants to merge 1 commit into
Open
Muneer Alam (Muneer320) wants to merge 1 commit into
Muneer Alam (Muneer320) wants to merge 1 commit into
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Form serialization trims field names, so
fieldandfieldare sent under the same name. Encode the original name in the string, object and non-parsable-object writer paths.Regressions cover leading/trailing ASCII whitespace, whitespace-only names, Unicode whitespace, distinct-field preservation and public parser lookup. Ordinary names and names requiring percent-encoding remain covered. Existing empty/absent input behavior is unchanged.
Related Issue
Fixes #892.
Testing Instructions
packages/serialization/form, installrequirements-dev.txtand runpytest.suggestion-modeconfiguration diagnostic; its optional cache could not be written in the local sandbox.The public reproducer and tests use local serialization only. No service calls or credentials are required.