Skip to content

Add missing content-mapper LSP fallbacks - #65557

Draft
Andrew Branch (andrewbranch) wants to merge 4 commits into
mainfrom
copilot/fix-content-mapper-fallbacks
Draft

Andrew Branch (andrewbranch) wants to merge 4 commits into
mainfrom
copilot/fix-content-mapper-fallbacks

Conversation

@andrewbranch

@andrewbranch Andrew Branch (andrewbranch) commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Fixes #65525

Analysis

Several dynamically registered LSP methods lacked fallbacks after content-mapper removal, exposing unknown-script-kind errors as internal errors.

Fix

  • Fallbacks: Return null for the omitted methods, including semantic tokens, formatting, call hierarchy, and completion-item resolve.
  • Compatibility: Preserve empty diagnostic reports and stale code-lens ContentModified responses.
  • Coverage: Extend the protocol integration test to exercise requests after mapper removal.

Copilot Checklist

Successfully ran npx hereby validate --all, including API and ancillary checks.

  • npx hereby validate
  • npx hereby validate --api (for TypeScript API changes)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@typescript-automation typescript-automation Bot added For Uncommitted Bug PR for untriaged, rejected, closed or missing bug and removed For Milestone Bug PRs that fix a bug with a specific milestone labels Nov 17, 2026
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@andrewbranch Andrew Branch (andrewbranch) changed the title [WIP] Fix missing content-mapper fallbacks causing internal LSP errors Add missing content-mapper LSP fallbacks Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing content-mapper fallbacks cause internal LSP errors

2 participants