Repository navigation
Conversation
FakeGitHub keeps one release per tag (draft, asset names) behind the Client trait, logs the write calls, and fails the test on a gh call it has no answer for. Two scenarios use it: a release that lacks a required asset and is repaired from its tag over four runs, and a version edited by hand that status does not report as incomplete. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…asset Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A scenario over several runs of the tool, such as "a release fails, the branch moves, a recovery run starts", is long to write today. Each test in
tests/e2e.rsscripts the answers ofghby hand with a closure. So these scenarios were run by hand on verwalter-playground, where each one needs merges and several minutes per run.This PR is based on the test branch
playground/0.31.0-pre.3, because the scenarios need #105, #109, #110 and #111. It can go tomainafter those merge.Change
tests/e2e.rsonly. Nothing undersrc/changes, and no existing test changes.FakeGitHub. It keeps a release per tag with its draft flag and its asset names. It answers theghcalls ofrelease,publishandstatus: view, create, upload, edit and delete of a release, and an empty PR list. A call that it does not know fails, and the fake panics at the end of the test if one occurred, becausestatusignores somegherrors.scenario_a_release_that_lacks_an_asset_is_repaired_from_its_tag, four steps on one repository:statusnames the missing file.ref=<tag>. Nothing is uploaded.publishfails with the changed-source reason. The command does not run.statusis complete.scenario_a_version_edited_by_hand_is_not_an_incomplete_release.Verified
cargo fmt --all -- --check,cargo clippy --all-targets -- -D warningsandcargo testpass (85 unit, 2 main, 38 end-to-end).0.31.0-pre.1and0.31.0-pre.2.Not done yet
statusandreleasecall the registry request directly, and onlypublishtakes a replacement. A scenario with "the registry has the version now" needs that parameter in both.release_with_assets_then_abandon,release_publishes_a_draft_only_with_its_required_assets,publish_leaves_a_draft_without_a_required_asset.🤖 Generated with Claude Code