Repository navigation
agentdb: a numeric error code with name and description; wire deadline, frame bounds and capabilities - #1983
Merged
Merged
Conversation
…ave applied and where it may be retried
🦋 Changeset detectedLatest commit: fce1284 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…t and seq, bounds frames and lists capabilities One deadline: ClientMessage.deadline_ms is the caller's budget at send. Keyed requests: Hello.client_id with ClientMessage.seq keys a write so a resend applies it at most once; Batch.if_tip applies only at that tip. Hello.max_frame bounds every server frame; HelloOk.capabilities lists what the server supports beyond the base protocol.
… transaction Keyed requests: a Batch with if_tip replaces a transaction held across requests.
… a window of each client's last 16 keyed writes
…the codes and what they mean are agent-db's The ErrorCode enum and its applied and retry options leave the protocol: agent-db keeps its table of codes, and a client branches on the number. Error keeps name and description in fields 1 and 2, so an older reader of the string code reads the name. Keyed writes are gone: Hello.client_id, ClientMessage.seq and the KEYED_WRITES capability.
theomonnom
marked this pull request as ready for review
November 16, 2026 03:04
davidzhao
approved these changes
Nov 16, 2026
…nothing shipped on this wire
…est with its configured timeout
theomonnom
added a commit
to livekit/rust-sdks
that referenced
this pull request
Nov 16, 2026
Moves the protocol submodule to livekit/protocol c6a16489 (livekit/protocol#1983): AgentDB.Wire.Error is {code, name, description}; Hello carries client_version; if_tip, capabilities, max_frame and deadline_ms are removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentDB.Wire.Error carries a numeric
code, itsnameand adescription. The protocol declares no codes: agent-db keeps the table, each code saying whether a request answered with it may have applied and whether it may be retried, and clients branch on the number.nameanddescriptionkeep fields 1 and 2, so a reader of the old string code reads the name.Wire fields:
Hello.client_version,Hello.max_frame(0 = server default);HelloOk.capabilities(repeatedWire.Capability:IF_TIP);ClientMessage.deadline_ms(budget at send, 0 = server default);Batch.if_tip(optional int64, like every tip). Begin, Commit and Rollback are unsupported: a request is one transaction.