Repository navigation
feat(lk): lk agent simulate compare prints the compare page for runs, or their data with --json - #1107
Draft
u9g wants to merge 5 commits into
Draft
feat(lk): lk agent simulate compare prints the compare page for runs, or their data with --json#1107u9g wants to merge 5 commits into
u9g wants to merge 5 commits into
Conversation
Contributor
Author
|
Demo against two real staging runs: sim-compare.mp4 |
… for runs, or their data with --json
u9g
force-pushed
the
jason/sim-compare
branch
from
November 6, 2026 23:08
f6828da to
79378ec
Compare
With credentials from LIVEKIT_* or inline flags the project ID is empty, and compare printed /projects//simulations/compare?... and exited 0. Return no URL in that case, as simulationDashboardURL does, and say how to get one.
export only prints finished runs, so stdout is a complete export or nothing, but compare --json printed whatever state each run was in. Hold every run to the same check before printing anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
lk agent simulate compare RUN_ID RUN_ID [RUN_ID...]. It compares finished or running simulation runs by ID, with the first run as the baseline. It prints one of two things:…/projects/<project>/simulations/compare?runs=a,b.--json:{"version": 1, "runs": [...]}, where each run is exactly whatlk agent simulate exportprints for it (the run, plus its decoded summary), in the order given. Likeexport, it refuses a run that hasn't finished, and prints nothing unless every run is ready.It takes 2 to 4 distinct run IDs. Without a project ID (credentials from
LIVEKIT_*or flags), it asks for--projector--jsoninstead of printing a broken link. 4 is the compare page's limit: the page drops any runs past it, so the CLI rejects them instead.No protocol or backend change. The
--compare KNOB=…flag this PR used to add is gone.Commits: a refactor that splits building a run's export JSON from encoding it, then the subcommand.