Skip to content

Announce the LiveKit Cloud API beta in the CLI banner - #1101

Open
JackNDwyer wants to merge 4 commits into
mainfrom
jack/cloud-api-cli-banner
Open

JackNDwyer wants to merge 4 commits into
mainfrom
jack/cloud-api-cli-banner

Conversation

@JackNDwyer

@JackNDwyer JackNDwyer commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Important

@rektdeckard to-do: don't merge until a CLI release that includes #1117 is out. lk fetches banner.json from main at run time, so merging this shows the message to every CLI user right away. If that release isn't 2.19.5, change both versions below to match it.

Why

The Cloud API open beta launches Thursday, Nov 12. This and What's new in the dashboard are the in-product announcements. banner.json on main is empty today.

The banner prints before every command a person runs in a terminal, so it shouldn't keep telling people who are already signed in to sign in. #1117 adds the signed-out audience that makes that possible.

What changed

Two entries in banner.json:

Before merging

How I tested it

go test ./cmd/lk/ -run Banner passes, including TestBannerFileAudiencesExcludeOldCLIs, which reads the committed banner.json.

🤖 Generated with Claude Code

CLIs that support --user-auth (2.19.2 and later) are told to sign in and
try it. Older CLIs are told to update. The banner goes live for every lk
user as soon as this merges, so it merges on launch day, Nov 10.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread banner.json Resolved
2.19.3 changed how list results are reported, so 2.19.2 is told to
update along with older versions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@JackNDwyer
JackNDwyer marked this pull request as ready for review November 4, 2026 23:07
@JackNDwyer

Copy link
Copy Markdown
Contributor Author

Looked into this: the audience field only adds a message for signed-in users but it'd still show the other message too. So two banners - I'm inclined to say we just run it as is

@rektdeckard

Copy link
Copy Markdown
Member

@JackNDwyer yeah, this is fine for now. Keeping unapproved so we don't merge it by accident and can bump the version if need be.

@JackNDwyer

Copy link
Copy Markdown
Contributor Author

Thank you, and good call 🤝

2.19.3 breaks against the Public API's new list format, so only the next
release can sign in and read sessions. The docs link goes to the CLI
guide's "Improve your agent" section, which is what the banner describes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Devin Review: 1 flag

Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

#1117

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@JackNDwyer

Copy link
Copy Markdown
Contributor Author

@rektdeckard change of plan: please don't merge this on Thursday. It now waits for a CLI release that includes #1117, so the sign-in prompt only shows to people who aren't signed in yet. No rush on that release; it can ride the next one. When it's out, set both versions in banner.json to that release if it isn't 2.19.5, then merge.

@rektdeckard

Copy link
Copy Markdown
Member

@JackNDwyer ack 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants