Repository navigation
Announce the LiveKit Cloud API beta in the CLI banner - #1101
JackNDwyer wants to merge 4 commits into
Conversation
CLIs that support --user-auth (2.19.2 and later) are told to sign in and try it. Older CLIs are told to update. The banner goes live for every lk user as soon as this merges, so it merges on launch day, Nov 10. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2.19.3 changed how list results are reported, so 2.19.2 is told to update along with older versions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Looked into this: the |
|
@JackNDwyer yeah, this is fine for now. Keeping unapproved so we don't merge it by accident and can bump the version if need be. |
|
Thank you, and good call 🤝 |
2.19.3 breaks against the Public API's new list format, so only the next release can sign in and read sessions. The docs link goes to the CLI guide's "Improve your agent" section, which is what the banner describes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
#1117 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@rektdeckard change of plan: please don't merge this on Thursday. It now waits for a CLI release that includes #1117, so the sign-in prompt only shows to people who aren't signed in yet. No rush on that release; it can ride the next one. When it's out, set both |
|
@JackNDwyer ack 🫡 |
Important
@rektdeckard to-do: don't merge until a CLI release that includes #1117 is out.
lkfetchesbanner.jsonfrom main at run time, so merging this shows the message to every CLI user right away. If that release isn't 2.19.5, change bothversionsbelow to match it.Why
The Cloud API open beta launches Thursday, Nov 12. This and What's new in the dashboard are the in-product announcements.
banner.jsonon main is empty today.The banner prints before every command a person runs in a terminal, so it shouldn't keep telling people who are already signed in to sign in. #1117 adds the
signed-outaudience that makes that possible.What changed
Two entries in
banner.json:Before merging
versionsmatch that release.How I tested it
go test ./cmd/lk/ -run Bannerpasses, includingTestBannerFileAudiencesExcludeOldCLIs, which reads the committedbanner.json.🤖 Generated with Claude Code