Repository navigation
Leave the default max bitrate unset until negotiation sets one - #298
Open
hiroshihorie wants to merge 1 commit into
Open
hiroshihorie wants to merge 1 commit into
hiroshihorie wants to merge 1 commit into
Conversation
PeerConnectionFactory gave every Call a 2 Mbps max until the first negotiated media section replaced it. No media is sent before then, so that max only clamped a start bitrate set through SetBitrate() before the first answer, and the clamped start was kept after negotiation lifted the max. WebRTC-PcFactoryDefaultBitrates can still set a max.
hiroshihorie
marked this pull request as ready for review
September 24, 2026 09:19
cloudwebrtc
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PeerConnectionFactorygives each Call a 2 Mbps max until the first negotiated media section replaces it. No media is sent before then, so that max only clamps a start bitrate set throughSetBitrate()before the first answer, and the clamped value is kept after negotiation lifts the max. A publisher that sets a 3 Mbps start before its first answer starts at 2 Mbps.The default max is now unset.
WebRTC-PcFactoryDefaultBitratescan still set one.Testing
PeerConnectionFactoryDependenciesTestcases record the Call's bitrate config. The default case fails with a 2 Mbps max without this change.peerconnection_unittestson macOS arm64 debug: 2976 passed, 0 failed.DisableAndEnableAudioRecordingfails, and the fake clock tests abort on a test clock check when run after other tests. Both also happen onm150_releasewithout this change, and the fake clock tests pass on their own.