Skip to content

Leave the default max bitrate unset until negotiation sets one - #298

Open
hiroshihorie wants to merge 1 commit into
m150_releasefrom
hiroshi/unset-default-max-bitrate
Open

hiroshihorie wants to merge 1 commit into
m150_releasefrom
hiroshi/unset-default-max-bitrate

Conversation

@hiroshihorie

Copy link
Copy Markdown
Member

PeerConnectionFactory gives each Call a 2 Mbps max until the first negotiated media section replaces it. No media is sent before then, so that max only clamps a start bitrate set through SetBitrate() before the first answer, and the clamped value is kept after negotiation lifts the max. A publisher that sets a 3 Mbps start before its first answer starts at 2 Mbps.

The default max is now unset. WebRTC-PcFactoryDefaultBitrates can still set one.

Testing

  • New PeerConnectionFactoryDependenciesTest cases record the Call's bitrate config. The default case fails with a 2 Mbps max without this change.
  • peerconnection_unittests on macOS arm64 debug: 2976 passed, 0 failed. DisableAndEnableAudioRecording fails, and the fake clock tests abort on a test clock check when run after other tests. Both also happen on m150_release without this change, and the fake clock tests pass on their own.

PeerConnectionFactory gave every Call a 2 Mbps max until the first
negotiated media section replaced it. No media is sent before then, so that
max only clamped a start bitrate set through SetBitrate() before the first
answer, and the clamped start was kept after negotiation lifted the max.

WebRTC-PcFactoryDefaultBitrates can still set a max.
@hiroshihorie
hiroshihorie marked this pull request as ready for review September 24, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants