Repository navigation
Fix RTCStatsCollector crash for stopped transceivers - #262
Merged
Merged
Conversation
Backport of upstream 0b6045b (webrtc-review.googlesource.com/c/src/+/458680, landed in M147). A getStats issued between transceiver.stopInternal() and the answer applying the rejected m-section prepares an RtpTransceiverStatsInfo with mid/transport_name set but no initialized TrackMediaInfoMap; the produce step on the network thread then dereferences the disengaged media-info optional. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
cloudwebrtc
approved these changes
Jul 6, 2026
cloudwebrtc
pushed a commit
that referenced
this pull request
Jul 16, 2026
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
sabahattinseven
added a commit
to sabahattinseven/client-sdk-android-fast-match
that referenced
this pull request
Oct 3, 2026
Upstream v2.28.2 moved to 144.7559.14. The fork takes 144.7559.15, the last m144 build, which adds livekit/libwebrtc#288 on top: prewarmRecording() and requestStartRecording() return false instead of throwing AssertionError when AudioRecord init failed. FastMatchSession prewarms the mic on every warm-up, so that path is live here. The other three .15 backports are iOS/macOS-only. Fixes relevant to fast-match that arrive with the .09 -> .15 delta: - livekit/libwebrtc#262: RTCStatsCollector no longer dereferences a disengaged optional for a stopped transceiver (the network-thread SIGABRT class the SDK worked around with metrics-poll and teardown sequencing). - livekit/libwebrtc#266: AudioRecord is no longer released under a live reader when the stop join times out on rapid capture stop/start cycles. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of upstream
0b6045b38b("Prevent RTCStatsCollector crash for stopped transceivers", M147). AgetStatsissued betweentransceiver.stopInternal()and the answer applying the rejected m-section prepares anRtpTransceiverStatsInfowithmid/transport_nameset but an uninitializedTrackMediaInfoMap, soProduceVideoRTPStreamStats_ndereferences the disengagedvideo_media_info()optional on the network thread (libc++ hardening abort in release,Check failed: is_initialized_in debug). This adds the missingkStoppedguard toProduceRTPStreamStats_nplus the upstream regression test, which crashes before and passes after this change.Resymbolicated crash stack (LiveKitWebRTC 144.7559.10; identical shape on 144.7559.08):
Fixes livekit/client-sdk-swift#1056
🤖 Generated with Claude Code