Repository navigation
rpcserver: expose the opening push amount for closed channels - #11599
Closed
AmanBoronbaev wants to merge 2 commits into
Closed
AmanBoronbaev wants to merge 2 commits into
AmanBoronbaev wants to merge 2 commits into
Conversation
Report the initial balance of the non-initiating party in both channel listings. The close summary already loads the historical opening state, so reporting the push does not add a database lookup.
AmanBoronbaev
marked this pull request as ready for review
November 21, 2026 10:14
Collaborator
|
Hi @AmanBoronbaev, thanks for taking the time to put this together. Per the new contributor section of the contribution guidelines, we don't prioritize review of PRs from authors without a track record in the project. Given the current review load, I'm closing this rather than letting it sit. Since #4490 already covers this, we'll handle it from that issue; if a fix is warranted a maintainer will pick it up. If you'd like to contribute going forward, reviewing open PRs and helping triage issues is the path we recommend. It's a stronger signal of understanding than a first patch, and it makes it a lot easier for us to prioritize your PRs later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4490.
ClosedChannelsnow returnspush_amount_sat, the amount the initiator sent to the other peer when opening the channel. It uses the same opening balance asListChannelson either side of the channel. The close-summary path already loads the historical channel, so this adds no database read or migration.The value is zero when no funds were pushed or this node lacks the original opening balances. Some older records were migrated with zero balances. The settled balance at close cannot recover the original push.
The protobuf and REST schemas include the new field. The unit test checks both parties’ views, zero push and sub-satoshi truncation. In the regtest integration case, Alice pushes 5,000,000 sat to Bob, a cooperative close is reorganized, and both nodes report 5,000,000 sat in their closed-channel summaries after final confirmation.
Verification
Both passed locally using the btcd backend. The protobuf and OpenAPI outputs were regenerated with the project’s pinned compiler and generators.