Repository navigation
Let :gen_tcp pick a random port for us - #22
Closed
krisalyssa wants to merge 1 commit into
Closed
krisalyssa wants to merge 1 commit into
krisalyssa wants to merge 1 commit into
Conversation
jeffutter
requested changes
Feb 18, 2018
jeffutter
left a comment
Member
There was a problem hiding this comment.
I would prefer nectar to default to a port (for when you mix nectar.server and have tests pass in 0 for a random port.
|
|
||
| def start(_type, args) do | ||
| port = Keyword.get(args, :port, 8080) | ||
| requested_port = Keyword.get(args, :port, 0) |
Member
There was a problem hiding this comment.
This is good for tests, but it would be nice to default a port for when you mix nectar.server similar to how phoenix defaults to 4000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.