Repository navigation
fix: keep selected plugins when installing a BoM - #480
Open
josh-burton wants to merge 1 commit into
Open
josh-burton wants to merge 1 commit into
josh-burton wants to merge 1 commit into
Conversation
Refresh the stale-bot-closed PR invertase#452 on current upstream main. Resolve prompt indexes and defaults against the filtered BoM plugin list so selections do not shift and an unavailable installed plugin cannot cause a RangeError. Parse positional BoM versions independently of flags and distinguish global CLI version requests from the install version option. Validation: 79 credential-free Dart tests passed, including 11 install regressions; package analysis and changed-file formatting passed. Firebase integration CI requires a maintainer trigger. Co-Authored-By: GPT-6 <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #468, which closed for inactivity. Rebased onto
1ff52a0.When a BoM omits Dynamic Links, choosing Messaging in the install prompt can install In-App Messaging and remove Messaging. The prompt filters unavailable plugins, but the installer interprets its selection indexes against the full plugin list.
Use the same filtered list for labels, defaults, and returned selections. This also prevents an installed plugin missing from the BoM from producing a negative index while building the prompt defaults.
Read positional BoM versions from the parsed positional arguments so they work alongside install flags. Use the command parser to distinguish the global CLI version flag from the install command’s BoM version option.
Validation
dart analyze --fatal-infos, changed-file formatting, andgit diff --checkpassed.--verbose --versionandinstall --help.