Skip to content

fix: keep selected plugins when installing a BoM - #480

Open
josh-burton wants to merge 1 commit into
invertase:mainfrom
josh-burton:codex/bom-plugin-selection
Open

josh-burton wants to merge 1 commit into
invertase:mainfrom
josh-burton:codex/bom-plugin-selection

Conversation

@josh-burton

Copy link
Copy Markdown
Contributor

Replaces #468, which closed for inactivity. Rebased onto 1ff52a0.

When a BoM omits Dynamic Links, choosing Messaging in the install prompt can install In-App Messaging and remove Messaging. The prompt filters unavailable plugins, but the installer interprets its selection indexes against the full plugin list.

Use the same filtered list for labels, defaults, and returned selections. This also prevents an installed plugin missing from the BoM from producing a negative index while building the prompt defaults.

Read positional BoM versions from the parsed positional arguments so they work alongside install flags. Use the command parser to distinguish the global CLI version flag from the install command’s BoM version option.

Validation

  • 112 tests passed across 10 credential-free suites, including 11 install regressions.
  • dart analyze --fatal-infos, changed-file formatting, and git diff --check passed.
  • Checked the CLI entry point with --verbose --version and install --help.
  • Firebase-backed integration tests were not run locally.

Refresh the stale-bot-closed PR invertase#452 on current upstream main. Resolve prompt indexes and defaults against the filtered BoM plugin list so selections do not shift and an unavailable installed plugin cannot cause a RangeError. Parse positional BoM versions independently of flags and distinguish global CLI version requests from the install version option.

Validation: 79 credential-free Dart tests passed, including 11 install regressions; package analysis and changed-file formatting passed. Firebase integration CI requires a maintainer trigger.

Co-Authored-By: GPT-6 <noreply@openai.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant