Repository navigation
Make RELATE language-agnostic by allowing specification of Docker containers. - #674
Conversation
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
==========================================
+ Coverage 88.42% 96.23% +7.81%
==========================================
Files 45 45
Lines 11117 11217 +100
Branches 2065 2085 +20
==========================================
+ Hits 9830 10795 +965
+ Misses 1097 327 -770
+ Partials 190 95 -95
Continue to review full report at Codecov.
|
|
#675 should have cleared up all the CI failures. (Sorry about having those hanging for so long.) Could you merge in master and see what happens? |
|
BUT it's going to be pulling in the default Docker image, not the new one. See |
|
I've built and pushed diff --git a/docker-image-run-py/Dockerfile b/docker-image-run-py/Dockerfile
index 4e9eacf2..f73228e1 100644
--- a/docker-image-run-py/Dockerfile
+++ b/docker-image-run-py/Dockerfile
@@ -3,9 +3,6 @@ MAINTAINER Andreas Kloeckner <inform@tiker.net>
EXPOSE 9941
RUN useradd runcode
-# Temporarily needed for pandas
-RUN echo "deb http://httpredir.debian.org/debian unstable main contrib" >> /etc/apt/sources.list
-RUN echo "deb http://httpredir.debian.org/debian experimental main contrib" >> /etc/apt/sources.list
RUN echo 'APT::Default-Release "testing";' >> /etc/apt/apt.conf
RUN apt-get update
@@ -40,8 +37,6 @@ RUN apt-get -y -o APT::Install-Recommends=0 -o APT::Install-Suggests=0 install \
RUN apt-get clean
RUN fc-cache
-RUN pip3 install numpy==1.16.1
-
RUN mkdir -p /opt/runcode
ADD runcode /opt/runcode/
COPY code_feedback.py /opt/runcode/
@@ -53,7 +48,8 @@ RUN echo "savefig.dpi : 80" >> /etc/matplotlibrc
RUN echo "savefig.bbox : tight" >> /etc/matplotlibrc
# RUN pip3 install --upgrade tensorflow
+# RUN find /usr/lib/python3/ -name '*cpython-37m*.so' -delete
+
RUN rm -Rf /root/.cache
-RUN find /usr/lib/python3/ -name '*cpython-37m*.so' -delete
# may use ./flatten-container.sh to reduce disk space(and, for future PRs (and maybe this one), could you tick the box that allows me to push?) |
|
Should this also include changing the name of the setting |
|
The box |
Yes. My (and will have |
|
I should probably hardcode a fallback in case of an older |
Could you spell out |
That's my question. Should I wait with merging this until those changes are included? I.e. could you let me know when/whether this is ready for review? |
|
Current major references to
Current hardcoded references to
I have just updated the Dockerfile per your diff above and also fixed @inducer My actionable question (assuming checks pass) is whether to swap out the hardcoded i386 version for the generic runcode version of the image. |
|
@inducer ☝️ Please see the question on the hardcoded i386 Docker image. |
Yes, please do. Sorry about the delay in responding. I've had a pretty rough two weeks, and I'm still battling a cold... |
|
No problem. I think I may be getting the cold going around myself... |
|
Bumping this, then I'll finalize the Octave addition and write up documentation. |
|
Sorry for the delay! Just one minor doc wrinkle to go. |
|
Thanks! |
This contributes further towards #631, creating support for non-Python questions.
The current version (
c6943a7) adds support for specifying Docker containers, although the default on everything is still Python. Terminology such asrunpyhas been switched toruncode. The Docker imageinducer/relate-runcode-pythonhas been introduced.