You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Should responses with content-type application/json have UTF-8 encoding by default? #714
Currently, responses without a specified charset encoding in the header are stored internally with binary/ascii 8bit encoding. According to the spec, the specified charset should be redundant. Should the default for json responses by utf-8 instead?
JSON text exchanged between systems that are not part of a closed
ecosystem MUST be encoded using UTF-8 [RFC3629].
Previous specifications of JSON have not required the use of UTF-8
when transmitting JSON text. However, the vast majority of JSON-
based software implementations have chosen to use the UTF-8 encoding,
to the extent that it is the only encoding that achieves
interoperability.
Also in RFC8259, at the end of Section 11 (or just above of Section 12):
Note: No "charset" parameter is defined for this registration.
Adding one really has no effect on compliant recipients.
@ixti@tarcieri thanks for quick turn around. Not to rush, but do yall have any idea when I can expect a release with this change?
I came across this related to work and so I'm figuring out if I should make changes to support this internally or if I can wait and update the gem (when it's out).
Activity
tarcieri commentedon Jun 13, 2022
That seems like a reasonable default, yes
drwl commentedon Jun 14, 2022
I can try to put up a PR. Where do you suggest this code change take place?
My initial thought is to change HTTP::Response initializer:
thoughts?
tarcieri commentedon Jun 14, 2022
Sounds good to me /cc @ixti
ixti commentedon Jun 16, 2022
@tarcieri I like the idea. Reviewed the PR.
drwl commentedon Jun 16, 2022
@ixti @tarcieri thanks for quick turn around. Not to rush, but do yall have any idea when I can expect a release with this change?
I came across this related to work and so I'm figuring out if I should make changes to support this internally or if I can wait and update the gem (when it's out).
ixti commentedon Jun 17, 2022
Released as 5.1.0
ixti commentedon Oct 11, 2022