Repository navigation
Add test for </button> closing <p> - #146
Merged
Merged
Conversation
fb55
added a commit
to inikulin/parse5
that referenced
this pull request
May 8, 2022
Fixes #533 A PR with a test was opened at html5lib/html5lib-tests#146
Ms2ger
approved these changes
May 9, 2022
Contributor
|
I don't believe My read of the standard is
Was this a copy and paste error or have I missed something in the standard that causes these three errors? |
Contributor
|
@stevecheckoway Yes, you are right, there are no errors in this test case |
Contributor
Author
|
Yeah, this was an oversight on my part. Sorry for that! |
Contributor
|
@alexander-akait @fb55 Do you think it's possible to merge @stevecheckoway's PR at #149 if his analysis is correct? |
Contributor
|
@flavorjones Sorry, I don't have permissions to merge 😞 |
Contributor
Author
|
I don't have permissions either. @Ms2ger how do you feel about adding additional collaborators to this repo? |
Contributor
|
I don't have permissions to add anyone else, maybe @jgraham? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #143