Repository navigation
fix(cli): a new blank project starts on a black frame, not grey - #6614
Merged
Merged
Conversation
![heygengenesis[bot]](https://avatars.githubusercontent.com/in/2913576?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: REQUEST CHANGES · 1 blocker · 0 important · 0 nits · head 3342e635
- blocker (process): this is a fix PR, but the body has no
fails without the fix:line naming the test. Add e.g.fails without the fix: packages/cli/src/templates/blank.test.ts ("starts on a black frame").
The code looks right to me: --ground: #000 matches from-file's #000 background, the new test catches the grey value, no other template sets --ground, and CI is green. I'll approve once the line is there.
miguel-heygen
enabled auto-merge
October 28, 2026 04:12
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #5651 the blank template's
--groundwas#6b6b6b(it was#0a0a0abefore), so every new blank project rendered a grey frame. It is now#000, matching the from-file template. The variable stays.A template test reads the blank template and fails if
--groundis anything but#000; it fails on the grey value and passes on this change.fails without the fix: packages/cli/src/templates/blank.test.ts ("starts on a black frame")
Small on purpose: a one-line fix to a template every new blank project starts from, so it ships alone.