Skip to content

fix(examples): align K8s Chrome pin with managed version - #6363

Merged
miguel-heygen merged 2 commits into
heygen-com:mainfrom
user-github-me:fix/k8s-chrome-pin
Oct 26, 2026
Merged

miguel-heygen merged 2 commits into
heygen-com:mainfrom
user-github-me:fix/k8s-chrome-pin

Conversation

@user-github-me

Copy link
Copy Markdown
Contributor

The Kubernetes distributed-renderer example still installs Chrome 148, which has the layered gradient-text defect addressed in #5338. Update it to 152.0.7977.30, matching the managed Linux browser and Cloud Run image.

This is the K8s follow-up accepted in review 5640641289.

Validation:

  • Verified the one-line pin change, version agreement, normal commit hooks and both comment checks.
  • Built the exact Dockerfile prefix through Chrome installation for Linux/amd64. Its installed Chrome 152 binary launched and passed the existing BeginFrame capture probe.
  • The complete example build passed system dependencies, FFmpeg verification and Chrome installation, then stopped at an existing ffmpeg-static download timeout during bun install. The complete image and current renderer remain unverified.

@miguel-heygen miguel-heygen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. The new pin matches the managed Chrome build exactly: CHROME_VERSION in packages/engine/src/services/chromeHostCeiling.ts:26 is 152.0.7977.30, and the Cloud Run Dockerfile:83 and Dockerfile.test:83 already install that version. #5338 moved those two from 148.0.7778.167 but missed this example, even though its comment at Dockerfile.example:110 says it follows the Cloud Run pin, so the old value was stale. PRODUCER_HEADLESS_SHELL_PATH is built from the same variable, so the install path follows the change, and no other reference to the old build remains.

Optional, not for this PR: a small check that compares these container pins with CHROME_VERSION would catch the next drift automatically.

Verdict: APPROVE
Reasoning: One-line pin now equals the repo's managed Chrome version and the Cloud Run pin, fixing a drift left by #5338; CI is green with path-filtered skips.

@miguel-heygen
miguel-heygen added this pull request to the merge queue Oct 26, 2026
Merged via the queue into heygen-com:main with commit a07ab50 Oct 26, 2026
59 checks passed
SanHsien added a commit to SanHsien/hyperframes that referenced this pull request Oct 26, 2026
Merge 20 more upstream commits (acd0bc3..ad4d3fa, v0.8.205: heygen-com#6403,
heygen-com#6363, heygen-com#6209, heygen-com#6395, heygen-com#6424, heygen-com#6426, heygen-com#6442, heygen-com#6430, heygen-com#6402, heygen-com#6435, heygen-com#6439,
heygen-com#6449, heygen-com#5436, heygen-com#6455 and docs). No conflicts. Record the 11 open PRs
heygen-com#6440-heygen-com#6458 and issue heygen-com#6443 in docs/DECISIONS.md (none adopted), re-check
the earlier open PRs, and advance the commit watermark to ad4d3fa, the
PR watermark to heygen-com#6458 and the issue watermark to heygen-com#6443.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants