Repository navigation
fix(scripts): run entrypoints from URL-encoded checkout paths - #6054
Draft
xiaoheiai4719-collab wants to merge 2 commits into
Draft
xiaoheiai4719-collab wants to merge 2 commits into
xiaoheiai4719-collab wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix repository script entrypoints in checkout paths containing URL-encoded characters.
Why
Seven repository scripts compare
import.meta.urlwith a rawfile://${process.argv[1]}string. Node URL-encodes the former but not the latter, so a checkout directory containing a space,%, or#can make the command silently skip its entrypoint and exit successfully without checking or generating anything.Related work
Related: #5543 decodes URL pathnames in other scripts and tests. This correction instead covers seven entrypoint guards and the SVG generator import; it does not duplicate that PR or close its scope. No separate issue is needed for this self-contained correction.
How
fileURLToPath(import.meta.url)in those seven guards.This does not change validation rules, generated content, package APIs, dependencies, or the Node version requirement. The fixtures never publish, contact GitHub, or write outside their temporary checkout.
Test plan
Updated by merging current main
03ed14615a2988d65ed793f004bcc4446ec89324into the existing branch. The single adjacent-import conflict retains bothfileURLToPathand upstreamgeneratedPaths; the complete upstream implementation and other upstream changes are included, not just the import.%and#.git diff --checkpassed.Full workspace build/tests, the complete root
test:scriptsaggregate, browser/render lanes, Windows/macOS and Node 22 were not rerun for this reconciliation. The original patch's Node 22.0.0 run passed the new regressions but had three unchanged TODO-link failures involvingURL.parse; that historical result is not a full-green or current-head Node 22 claim. Remote CI still requires its own execution and approval.AI-assisted implementation, reconciliation and tests: OpenAI Codex. The account owner has not personally rerun these checks.