Skip to content

docs(skills): frame-worker id prefix must not start with a digit - #5512

Closed
VaitaR wants to merge 1 commit into
heygen-com:mainfrom
VaitaR:docs/frame-worker-id-prefix
Closed

VaitaR wants to merge 1 commit into
heygen-com:mainfrom
VaitaR:docs/frame-worker-id-prefix

Conversation

@VaitaR

@VaitaR VaitaR commented Oct 13, 2026

Copy link
Copy Markdown

What

frame-worker-core.md now tells workers to prefix ids and classes with f<frame_id>- instead of <frame_id>-.

Why

frame_id always starts with a digit (03-feature), so following the old rule literally gives ids like 03-feature-title. #03-feature-title is an invalid selector for CSS, querySelector and GSAP. Workers either escape it (#\30 3-feature-title) or ship a broken selector, which the linter's unescaped-digit-id check then reports. In a real faceless-explainer run, two of eight frames hit this and needed a manual rename, including the escaped selectors and the string prefixes in the JS helpers.

Related work

None found.

How

One sentence in the shared worker contract. Ids stay unique per frame.

Test plan

  • Documentation updated
  • oxfmt --check and scripts/check-skill-mirror.mjs pass

@jrusso1020

Copy link
Copy Markdown
Collaborator

Thanks for the clear writeup. This one can be closed, because the file it edits no longer exists on main.

#5651 (merged 2026-10-21, 688229314) retired the workflow skills, and skills/hyperframes/references/frame-worker-core.md went with them. I checked current main: there is no frame-worker contract anywhere under skills/ and no remaining mention of frame_id, so the digit-prefix rule has nothing left to apply to.

The underlying point was right. #03-feature-title is an invalid selector, and the f prefix was a sensible fix while that contract existed.

Need: no, the target doc was deleted by #5651 · Size: ok · Reuse: nothing to reuse · Simpler: already minimal

— Rames

@jrusso1020 jrusso1020 closed this Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants