Repository navigation
Conversation
Collaborator
|
Thanks for the clear writeup. This one can be closed, because the file it edits no longer exists on main. #5651 (merged 2026-10-21, The underlying point was right. Need: no, the target doc was deleted by #5651 · Size: ok · Reuse: nothing to reuse · Simpler: already minimal — Rames |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
frame-worker-core.mdnow tells workers to prefix ids and classes withf<frame_id>-instead of<frame_id>-.Why
frame_idalways starts with a digit (03-feature), so following the old rule literally gives ids like03-feature-title.#03-feature-titleis an invalid selector for CSS,querySelectorand GSAP. Workers either escape it (#\30 3-feature-title) or ship a broken selector, which the linter's unescaped-digit-id check then reports. In a real faceless-explainer run, two of eight frames hit this and needed a manual rename, including the escaped selectors and the string prefixes in the JS helpers.Related work
None found.
How
One sentence in the shared worker contract. Ids stay unique per frame.
Test plan
oxfmt --checkandscripts/check-skill-mirror.mjspass