Repository navigation
chore(firestore): support Ruby 3.2 Hash#inspect output in samples tests - #36722
Open
torreypayne wants to merge 1 commit into
Open
torreypayne wants to merge 1 commit into
torreypayne wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
google-cloud-firestoresample acceptance assertions (get_data_test.rbandquickstart_test.rb) to accept both pre-Ruby 3.4 (:key=>val) and Ruby 3.4+ (key: val)Hash#inspectformatting via a sharedassert_hash_entryhelper inacceptance/helper.rb.Fixes
samples-oldest(Ruby 3.2) failures without breaking Ruby 3.4+/4.0. Verifiedrubocopand assertion behavior across Ruby 3.2, 3.3, and 4.0.Related to b/552162906 and b/580634043.