Repository navigation
Use NDK availability guard for mallopt instead of weak declaration - #2384
Open
charlesmunger wants to merge 1 commit into
Open
charlesmunger wants to merge 1 commit into
charlesmunger wants to merge 1 commit into
Conversation
dmah42
approved these changes
Nov 13, 2026
Member
|
do you mind checking that clang format issue? |
In Android NDK headers (<malloc.h>), mallopt() is declared with __INTRODUCED_IN(26) and guarded by __BIONIC_AVAILABILITY_GUARD(26). When __ANDROID_MIN_SDK_VERSION__ < 26, mallopt() is declared as a weak symbol if __ANDROID_UNAVAILABLE_SYMBOLS_ARE_WEAK__ is defined, and hidden otherwise. Instead of manually declaring mallopt() with __attribute__((weak)) and checking the deprecated __ANDROID_API__ macro, guard the __builtin_available() blocks with __ANDROID_MIN_SDK_VERSION__ >= 26 || defined(__ANDROID_UNAVAILABLE_SYMBOLS_ARE_WEAK__).
charlesmunger
force-pushed
the
ndkversioncheck
branch
from
November 13, 2026 22:49
2a9fe0a to
77c9a26
Compare
Contributor
Author
|
formatting fixed |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes extraneous weak declaration in favor of conditioning the version check on whether the android headers declare symbols as weak.