Repository navigation
Do not pass PerfCountersMeasurement to RunMemoryManager(). - #2379
Merged
Merged
Conversation
BenchmarkRunner::RunMemoryManager() only returns MemoryManager::Result and discards manager->results.counters (reported perf counters come from the timed DoNIterations() pass). Passing perf_counters_measurement_ptr here did unnecessary PMU reads and allocated a std::vector<std::pair<std::string, double>> inside State::PauseTimingImpl() during the memory pass. Pass nullptr instead, matching BenchmarkRunner::RunProfilerManager(). AI-assisted: this change was written with the help of an AI coding tool.
dmah42
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a tiny fix I found and extracted out from other changes.
BenchmarkRunner::RunMemoryManager() only returns MemoryManager::Result and discards manager->results.counters (reported perf counters come from the timed DoNIterations() pass). Passing perf_counters_measurement_ptr here did unnecessary PMU reads and allocated a
std::vector<std::pair<std::string, double>> inside State::PauseTimingImpl() during the memory pass.
Pass nullptr instead, matching BenchmarkRunner::RunProfilerManager().
Not a big deal, just a little tightening up.
AI-assisted: this change was written with the help of an AI coding tool.