Repository navigation
Add test showing that RunMemoryManager runs on skipped benchmarks - #2377
Merged
Merged
Conversation
Documents the current behavior in `BenchmarkRunner::DoOneRepetition()`: when a benchmark calls `SkipWithError()` before the loop, `RunMemoryManager()` still runs (`memory_manager_ran == true`) even though `CreateRunReport()` discards all memory results (`memory_iterations == 0`). A follow-up commit fixes `DoOneRepetition()` to skip `RunMemoryManager()` and flips this assertion. AI-assisted: this change was written with the help of an AI coding tool.
mhansen
force-pushed
the
skip_memory2
branch
from
November 11, 2026 23:59
eb45f5e to
864216d
Compare
dmah42
approved these changes
Nov 12, 2026
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've split this out so it's easy to tell the fix is doing something (red/green)
Documents the current behavior in
BenchmarkRunner::DoOneRepetition(): when a benchmark callsSkipWithError()before the loop,RunMemoryManager()still runs (memory_manager_ran == true) even thoughCreateRunReport()discards all memory results (memory_iterations == 0).A follow-up commit fixes
DoOneRepetition()to skipRunMemoryManager()and flips this assertion.AI-assisted: this change was written with the help of an AI coding tool.