Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/google/adk/sessions/in_memory_session_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,9 @@ def _create_session_impl(
):
raise AlreadyExistsError(f'Session with id {session_id} already exists.')
state_deltas = _session_util.extract_state_delta(state or {})
app_state_delta = state_deltas['app']
user_state_delta = state_deltas['user']
session_state = state_deltas['session']
app_state_delta = _copy_state(state_deltas['app'])
user_state_delta = _copy_state(state_deltas['user'])
session_state = _copy_state(state_deltas['session'])
if app_state_delta:
self.app_state.setdefault(app_name, {}).update(app_state_delta)
if user_state_delta:
Expand Down
44 changes: 44 additions & 0 deletions tests/unittests/sessions/test_session_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -3346,6 +3346,50 @@ async def test_get_user_state_copies_to_session_state_depth(light_copy):
)


@pytest.mark.parametrize('light_copy', [False, True])
@pytest.mark.parametrize('synchronous', [False, True])
async def test_in_memory_initial_state_uses_configured_copy_depth(
light_copy, synchronous
):
"""Changing initial state after creation respects the configured copy depth."""
override_feature_enabled(
FeatureName.IN_MEMORY_SESSION_SERVICE_LIGHT_COPY, light_copy
)
try:
service = InMemorySessionService()
initial_state = {
'app:config': {'values': ['original']},
'user:profile': {'values': ['original']},
'cart': {'values': ['original']},
# Dropped temporary values must not be traversed by deepcopy.
'temp:ignored': threading.Lock(),
}
kwargs = dict(
app_name='my_app', user_id='u1', session_id='s1', state=initial_state
)
if synchronous:
service.create_session_sync(**kwargs)
else:
await service.create_session(**kwargs)

for key in ('app:config', 'user:profile', 'cart'):
initial_state[key]['values'].append('changed')
initial_state['added'] = {'values': ['changed']}
stored = await service.get_session(
app_name='my_app', user_id='u1', session_id='s1'
)

expected_values = ['original', 'changed'] if light_copy else ['original']
assert stored.state == {
key: {'values': expected_values}
for key in ('app:config', 'user:profile', 'cart')
}
finally:
override_feature_enabled(
FeatureName.IN_MEMORY_SESSION_SERVICE_LIGHT_COPY, False
)


@pytest.mark.asyncio
@pytest.mark.parametrize('light_copy', [False, True])
@pytest.mark.parametrize('session_source', ['create', 'get', 'list'])
Expand Down
Loading