Skip to content

Fix transitive include in callable_custom.hpp - #2089

Open
Joy-less wants to merge 1 commit into
godotengine:masterfrom
Joy-less:reduce-unnecessary-include-in-widely-used-file
Open

Joy-less wants to merge 1 commit into
godotengine:masterfrom
Joy-less:reduce-unnecessary-include-in-widely-used-file

Conversation

@Joy-less

@Joy-less Joy-less commented Nov 18, 2026 •

Copy link
Copy Markdown

Includes string.hpp directly rather than transitively including it through string_name.hpp.

Unfortunately, this didn't seem to impact build times much, but oh well. I couldn't find any other obvious include fixes.

@Joy-less
Joy-less requested a review from a team as a code owner November 18, 2026 15:47
@Joy-less Joy-less changed the title Reduce unnecessary include in callable_custom.hpp Fix transitive include in callable_custom.hpp Nov 18, 2026

@dsnopek dsnopek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't expect this to change much practically, but it is better to include the thing the file is actually using :-)

@dsnopek dsnopek added the enhancement This is an enhancement on the current functionality label Nov 18, 2026
@dsnopek dsnopek added this to the 10.x milestone Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This is an enhancement on the current functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants