Repository navigation
chore: run the Chromium live checks in an isolated Chrome, and add the #111 read check - #116
Merged
Merged
Conversation
…#111 read check Each Chromium check (#107, #110, #111) launches its own Chrome on the fixture page with a temporary --user-data-dir, --no-first-run and --no-default-browser-check, then quits only that pid and deletes the profile. They no longer skip while the user's Chrome runs, and each starts with web accessibility off. #110 now waits for a page-only element (a table) on a fresh launch, and #111 reads the page the moment it opens: it passes on page text, or on a failure that says retried. Pause stays manual and user-only. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the #75 live-check gaps (items 1 and 2), plus a docs/live-checks.md refresh.
Isolated Chrome.
Session.launchChrome()launchesGoogle Chromefrom/Applicationsor~/Applicationswith a new temporary--user-data-dir,--no-first-run,--no-default-browser-checkand--new-window, opening the fixture page. It finds that pid's target throughdesktop_appsand waits for the fixture window.quitChrome()runsdesktop_quiton that target only. If the process is still running after 8 s, it sends SIGTERM to that child pid only, then deletes the profile. Each Chromium check gets its own launch and quits it in afinally; the global cleanup also covers Control-C. When Chrome isn't installed, the checks skip with a clear message instead of failing. The checks no longer skip while the user's own Chrome is running, and never touch its windows.Checks
web_accessibility: enabledand lists the controlled field, thenalready_on, then nothing when opted out. The assertions are unchanged; only the launch changed.desktop_wait element_appearsfor anAXTable(only the page has one) matches on a fresh launch withenabled. Atext_containswait withweb_accessibility: falsestill matches and reports nothing.retried: true, and fails on a failure withoutretried.Check sections are now grouped by the release that shipped them (0.13.0 / 0.12.0 / 0.11.0); #114 and #99 were sitting under 0.10.0.
Docs: the Chrome isolation, the #114 Finder paste fixtures, what #111 covers versus a forced incomplete read (still manual), and that Pause is user-only and never driven by the harness. #100 Pause and the Electron/activity checks stay manual.
No CHANGELOG entry, since this is a dev-harness change.
Verification
npm testpasses 70/70 andnpm run checkis clean.node scripts/live-check.mjs --listshows the new order.--only 107,110,111refuses on the locked screen, exits 2 and launches nothing.