Repository navigation
Cleanup initialize/close behavior to prevent initialized? checks everywhere #2096
Description
And perhaps we should implement a better version of close and Sentry.initialize? 🤔
Specifically:
- We don't erase hub variables,
@background_workerand@session_flusher Sentry.initialize?is backed by a simple boolean state that's changed bySentry.iniandSentry.close.
We would still need Sentry.initialize? in some places to stop some actions after the SDK is closed, but we don't need it for preventingnil value anymore, which is getting out of hand IMO.
Originally posted by @st0012 in #2084 (comment)
Activity
st0012 commentedon Sep 10, 2023
The eventual goal is to find a way to limit the number of
Sentry.initialized?check, so I went back to related issues:And just having this change wouldn't reduce any of those checks as we usually do
Sentry.foo.bar, where as long asSentry.fooreturnsnil, we'd still see the same error.So to actually achieve the goal, we need to ensure the data flow is not interrupted after
Sentry.closeand just block event-sending:nilif the SDK is not initialized at allClientshould block the event sendingIt'd avoid all the
Sentry.initialized?checks added above issues because they're already behind other initialization checks.